Bug 98685 - Should not part from channels in destroy handler
Summary: Should not part from channels in destroy handler
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: idle (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-11 11:58 UTC by Daniel Landau
Modified: 2019-12-03 20:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Fix (1.03 KB, patch)
2016-11-11 13:37 UTC, Daniel Landau
Details | Splinter Review

Description Daniel Landau 2016-11-11 11:58:48 UTC
My problem turned up when developing Polari. I use a bouncer, so I don't part from channels, I just deconnect from the bouncer and the bouncer is kept connected to actual servers and channels.

As a user I don't expect to get kicked out of my channels unless I actually explicitly ask to get out.

When quitting Polari normally nothing bad would happen, but when crashing, or signaling with Ctrl+C all my channels disappeared. Polari doesn't have a crash handler, but Telepathy-idle does. The problem doesn't seem to happen much anymore due to mission control, but parting from channels in a crash handler (for something else crashing, granted) is still strange and not something that bouncer users expect. Especially as a normal quit doesn't do that.

I already wrote a patch, here: https://github.com/daniellandau/telepathy-idle/commit/b3fe01ca224c35647e34d49d5dac70c126a0d7c6

I'll attach it as a file here too later today when I have the time.
Comment 1 Daniel Landau 2016-11-11 13:37:36 UTC
Created attachment 127915 [details] [review]
Fix
Comment 2 GitLab Migration User 2019-12-03 20:10:37 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-idle/issues/52.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.