Attachment 128636 Details for Bug 99183 – 0001-rtpbitrateadapter-should-make-no-adaption-by-default.patch

[patch] 0001-rtpbitrateadapter-should-make-no-adaption-by-default.patch

0001-rtpbitrateadapter-should-make-no-adaption-by-default.patch (text/plain), 1.24 KB, created by Jakub Adam on 2016-12-22 15:24:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jakub Adam

Created: 2016-12-22 15:24:49 UTC

Size: 1.24 KB

patch

obsolete

>From a57f3a39486fce372385488409c4456fffdfd61c Mon Sep 17 00:00:00 2001
>From: Jakub Adam <jakub.adam@ktknet.cz>
>Date: Thu, 14 Apr 2016 15:17:50 +0200
>Subject: [PATCH] rtpbitrateadapter: should make no adaption by default
>
>Description of "bitrate" property says 0 (the default value) means
>the element performs no adaption, and so one would assume it would
>remain passive until "bitrate" is set to some nonzero value. However,
>when "bitrate" is left unset, the adapter instead requests video in tiny
>128x96 resolution on its sink pad.
>
>In order for fs_rtp_bitrate_adapter_getcaps() to return peer_caps by
>default, the value of FsRtpBitrateAdapter::bitrate has to be initialized
>to G_MAXUINT.
>---
> gst/fsrtpconference/fs-rtp-bitrate-adapter.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/gst/fsrtpconference/fs-rtp-bitrate-adapter.c b/gst/fsrtpconference/fs-rtp-bitrate-adapter.c
>index e8684fd5..b52f5b9c 100644
>--- a/gst/fsrtpconference/fs-rtp-bitrate-adapter.c
>+++ b/gst/fsrtpconference/fs-rtp-bitrate-adapter.c
>@@ -161,6 +161,7 @@ fs_rtp_bitrate_adapter_init (FsRtpBitrateAdapter *self)
>   self->system_clock = gst_system_clock_obtain ();
>   self->interval = PROP_INTERVAL_DEFAULT;
> 
>+  self->bitrate = G_MAXUINT;
>   self->last_bitrate = G_MAXUINT;
> }
> 
>-- 
>2.11.0
>

Actions: View | Splinter Review

Attachments on bug 99183: 128636

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.