Created attachment 128636 [details] [review] 0001-rtpbitrateadapter-should-make-no-adaption-by-default.patch Description of "bitrate" property says 0 (the default value) means the element performs no adaption, and so one would assume it would remain passive until "bitrate" is set to some nonzero value. However, when "bitrate" is left unset, the adapter instead requests video in tiny 128x96 resolution on its sink pad. In order for fs_rtp_bitrate_adapter_getcaps() to return peer_caps by default, the value of FsRtpBitrateAdapter::bitrate has to be initialized to G_MAXUINT.
I merged a slightly improved version of your patch, where I also fixed th edocumenation to match the code. commit 11dde55cbaf5179e8e1885cf1483e538a8d5a4a9 Author: Jakub Adam <jakub.adam@ktknet.cz> Date: Thu Apr 14 15:17:50 2016 +0200 rtpbitrateadapter: should make no adaption by default Description of "bitrate" property says 0 (the default value) means the element performs no adaption, and so one would assume it would remain passive until "bitrate" is set to some nonzero value. However, when "bitrate" is left unset, the adapter instead requests video in tiny 128x96 resolution on its sink pad. In order for fs_rtp_bitrate_adapter_getcaps() to return peer_caps by default, the value of FsRtpBitrateAdapter::bitrate has to be initialized to G_MAXUINT. Also fix the comments to say that MAXUINT is no adaptation. https://bugs.freedesktop.org/show_bug.cgi?id=99183
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.