Attachment 133639 Details for Bug 102320 – 0001-update-desktop-database.c-Sort-output-within-lines-n.patch

[patch] 0001-update-desktop-database.c-Sort-output-within-lines-n.patch

0001-update-desktop-database.c-Sort-output-within-lines-n.patch (text/plain), 1.16 KB, created by Chris Lamb on 2017-08-20 15:06:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Lamb

Created: 2017-08-20 15:06:46 UTC

Size: 1.16 KB

patch

obsolete

>From 765ffd6ee578b05daecd2f250a51b93bcf5887ad Mon Sep 17 00:00:00 2001
>From: Chris Lamb <lamby@debian.org>
>Date: Sun, 20 Aug 2017 08:03:21 -0700
>Subject: [PATCH] update-desktop-database.c: Sort output within lines, not the
> just between them.
>
>Whilst working on the Reproducible Builds effort [0], we noticed
>that desktop-file-utils produces mimeinfo.cache files that are not
>reproducible.
>
>This is because it inherits the non-deterministic hash ordering of
>the mime_types_map data structure.
>
>Patch attached that sorts just prior to output.
>
> [0] https://reproducible-builds.org/
>---
> src/update-desktop-database.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/update-desktop-database.c b/src/update-desktop-database.c
>index 7f48357..165d133 100644
>--- a/src/update-desktop-database.c
>+++ b/src/update-desktop-database.c
>@@ -307,6 +307,7 @@ add_mime_type (const char *mime_type, GList *desktop_files, FILE *f)
> 
>   list = g_string_new (mime_type);
>   g_string_append_c (list, '=');
>+  desktop_files = g_list_sort (desktop_files, (GCompareFunc) g_strcmp0);
>   for (desktop_file = desktop_files;
>        desktop_file != NULL;
>        desktop_file = desktop_file->next)
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 102320: 133639

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.