Attachment 139046 Details for Bug 106203 – [PATCH] all: drop unused variables

[patch] [PATCH] all: drop unused variables

0001-all-drop-unused-variables.patch (text/plain), 7.17 KB, created by Lubomir Rintel on 2018-04-24 07:49:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Rintel

Created: 2018-04-24 07:49:53 UTC

Size: 7.17 KB

patch

obsolete

>From dfb987e41ed3fd2533493de6b20c37aba29af2f8 Mon Sep 17 00:00:00 2001
>From: Lubomir Rintel <lkundrak@v3.sk>
>Date: Tue, 24 Apr 2018 09:42:06 +0200
>Subject: [PATCH] all: drop unused variables
>
>Keeps build with GCC 8 happy.
>
>mm-base-call.c:758:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
>mm-base-call.c:822:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
>mm-base-sms.c:908:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
>mm-sms-list.c:331:25: warning: variable 'ctx' set but not used [-Wunused-but-set-variable]
>mm-iface-modem-messaging.c:1210:21: warning: variable 'storage_ctx' set but not used [-Wunused-but-set-variable]
>huawei/mm-plugin-huawei.c:183:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
>ublox/mm-plugin-ublox.c:161:24: warning: variable 'response' set but not used [-Wunused-but-set-variable]
>ublox/mm-plugin-ublox.c:159:24: warning: variable 'ctx' set but not used [-Wunused-but-set-variable]
>icera/mm-modem-helpers-icera.c:218:25: warning: variable 'first_free' set but not used [-Wunused-but-set-variable]
>novatel/mm-common-novatel.c:50:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
>---
> plugins/huawei/mm-plugin-huawei.c      | 3 +--
> plugins/icera/mm-modem-helpers-icera.c | 4 ++--
> plugins/novatel/mm-common-novatel.c    | 3 +--
> plugins/ublox/mm-plugin-ublox.c        | 5 +----
> src/mm-base-call.c                     | 6 ++----
> src/mm-base-sms.c                      | 3 +--
> src/mm-iface-modem-messaging.c         | 2 --
> src/mm-sms-list.c                      | 5 -----
> 8 files changed, 8 insertions(+), 23 deletions(-)
>
>diff --git a/plugins/huawei/mm-plugin-huawei.c b/plugins/huawei/mm-plugin-huawei.c
>index ba3bc009..0cefe71e 100644
>--- a/plugins/huawei/mm-plugin-huawei.c
>+++ b/plugins/huawei/mm-plugin-huawei.c
>@@ -180,12 +180,11 @@ curc_ready (MMPortSerialAt *port,
>             GTask *task)
> {
>     HuaweiCustomInitContext *ctx;
>-    const gchar *response;
>     GError *error = NULL;
> 
>     ctx = g_task_get_task_data (task);
> 
>-    response = mm_port_serial_at_command_finish (port, res, &error);
>+    mm_port_serial_at_command_finish (port, res, &error);
>     if (error) {
>         /* Retry if we get a timeout error */
>         if (g_error_matches (error,
>diff --git a/plugins/icera/mm-modem-helpers-icera.c b/plugins/icera/mm-modem-helpers-icera.c
>index 1b64d633..7c1da9a5 100644
>--- a/plugins/icera/mm-modem-helpers-icera.c
>+++ b/plugins/icera/mm-modem-helpers-icera.c
>@@ -215,7 +215,7 @@ mm_icera_parse_ipdpaddr_response (const gchar *response,
>     GError *local = NULL;
>     gboolean success = FALSE;
>     char **items;
>-    guint num_items, i, first_free;
>+    guint num_items, i;
>     gint num;
> 
>     g_return_val_if_fail (out_ip4_config, FALSE);
>@@ -240,7 +240,7 @@ mm_icera_parse_ipdpaddr_response (const gchar *response,
> 
>     /* Strip any spaces on elements; inet_pton() doesn't like them */
>     num_items = g_strv_length (items);
>-    for (i = 0, first_free = 0; i < num_items; i++)
>+    for (i = 0; i < num_items; i++)
>         items[i] = g_strstrip (items[i]);
> 
>     if (num_items < 7) {
>diff --git a/plugins/novatel/mm-common-novatel.c b/plugins/novatel/mm-common-novatel.c
>index f8c78f51..6932f5a9 100644
>--- a/plugins/novatel/mm-common-novatel.c
>+++ b/plugins/novatel/mm-common-novatel.c
>@@ -47,10 +47,9 @@ nwdmat_ready (MMPortSerialAt *port,
>               GAsyncResult *res,
>               GTask* task)
> {
>-    const gchar *response;
>     GError *error = NULL;
> 
>-    response = mm_port_serial_at_command_finish (port, res, &error);
>+    mm_port_serial_at_command_finish (port, res, &error);
>     if (error) {
>         if (g_error_matches (error,
>                              MM_SERIAL_ERROR,
>diff --git a/plugins/ublox/mm-plugin-ublox.c b/plugins/ublox/mm-plugin-ublox.c
>index fc9ec0c6..f4553a60 100644
>--- a/plugins/ublox/mm-plugin-ublox.c
>+++ b/plugins/ublox/mm-plugin-ublox.c
>@@ -156,15 +156,12 @@ quick_at_ready (MMPortSerialAt *port,
>                 GAsyncResult   *res,
>                 GTask          *task)
> {
>-    CustomInitContext *ctx;
>     MMPortProbe       *probe;
>-    const gchar       *response;
>     GError            *error = NULL;
> 
>-    ctx   = g_task_get_task_data     (task);
>     probe = g_task_get_source_object (task);
> 
>-    response = mm_port_serial_at_command_finish (port, res, &error);
>+    mm_port_serial_at_command_finish (port, res, &error);
>     if (error) {
>         /* On a timeout error, wait for READY URC */
>         if (g_error_matches (error, MM_SERIAL_ERROR, MM_SERIAL_ERROR_RESPONSE_TIMEOUT)) {
>diff --git a/src/mm-base-call.c b/src/mm-base-call.c
>index 186a3998..e70b2709 100644
>--- a/src/mm-base-call.c
>+++ b/src/mm-base-call.c
>@@ -755,11 +755,10 @@ call_hangup_ready (MMBaseModem *modem,
> {
>     MMBaseCall *self;
>     GError *error = NULL;
>-    const gchar *response;
> 
>     self = g_task_get_source_object (task);
> 
>-    response = mm_base_modem_at_command_finish (modem, res, &error);
>+    mm_base_modem_at_command_finish (modem, res, &error);
>     if (error) {
>         if (g_error_matches (error, MM_SERIAL_ERROR, MM_SERIAL_ERROR_RESPONSE_TIMEOUT)) {
>             g_task_return_error (task, error);
>@@ -819,9 +818,8 @@ call_send_dtmf_ready (MMBaseModem *modem,
>                       GTask *task)
> {
>     GError *error = NULL;
>-    const gchar *response = NULL;
> 
>-    response = mm_base_modem_at_command_finish (modem, res, &error);
>+    mm_base_modem_at_command_finish (modem, res, &error);
>     if (error) {
>         mm_dbg ("Couldn't send_dtmf: '%s'", error->message);
>         g_task_return_error (task, error);
>diff --git a/src/mm-base-sms.c b/src/mm-base-sms.c
>index 44d228b8..f9c16013 100644
>--- a/src/mm-base-sms.c
>+++ b/src/mm-base-sms.c
>@@ -905,10 +905,9 @@ store_ready (MMBaseModem *modem,
>              GTask *task)
> {
>     SmsStoreContext *ctx;
>-    const gchar *response;
>     GError *error = NULL;
> 
>-    response = mm_base_modem_at_command_finish (modem, res, &error);
>+    mm_base_modem_at_command_finish (modem, res, &error);
>     if (error) {
>         g_task_return_error (task, error);
>         g_object_unref (task);
>diff --git a/src/mm-iface-modem-messaging.c b/src/mm-iface-modem-messaging.c
>index 5bcd606e..70512904 100644
>--- a/src/mm-iface-modem-messaging.c
>+++ b/src/mm-iface-modem-messaging.c
>@@ -1207,10 +1207,8 @@ init_current_storages_ready (MMIfaceModemMessaging *self,
>                              GTask *task)
> {
>     InitializationContext *ctx;
>-    StorageContext *storage_ctx;
>     GError *error = NULL;
> 
>-    storage_ctx = get_storage_context (self);
>     if (!MM_IFACE_MODEM_MESSAGING_GET_INTERFACE (self)->init_current_storages_finish (
>             self,
>             res,
>diff --git a/src/mm-sms-list.c b/src/mm-sms-list.c
>index 22c2cd9a..8d6aa15b 100644
>--- a/src/mm-sms-list.c
>+++ b/src/mm-sms-list.c
>@@ -328,11 +328,6 @@ mm_sms_list_take_part (MMSmsList *self,
>                        MMSmsStorage storage,
>                        GError **error)
> {
>-    PartIndexAndStorage ctx;
>-
>-    ctx.part_index = mm_sms_part_get_index (part);
>-    ctx.storage = storage;
>-
>     /* Ensure we don't have already taken a part with the same index */
>     if (mm_sms_list_has_part (self,
>                               storage,
>-- 
>2.14.3
>

Actions: View | Splinter Review

Attachments on bug 106203: 139046

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.