Bug 106203 - [PATCH] all: drop unused variables
Summary: [PATCH] all: drop unused variables
Status: RESOLVED FIXED
Alias: None
Product: ModemManager
Classification: Unclassified
Component: general (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: ModemManager bug user
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-24 07:49 UTC by Lubomir Rintel
Modified: 2018-04-24 16:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
[PATCH] all: drop unused variables (7.17 KB, patch)
2018-04-24 07:49 UTC, Lubomir Rintel
Details | Splinter Review

Description Lubomir Rintel 2018-04-24 07:49:53 UTC
Created attachment 139046 [details] [review]
[PATCH] all: drop unused variables

Keeps build with GCC 8 happy.

mm-base-call.c:758:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
mm-base-call.c:822:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
mm-base-sms.c:908:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
mm-sms-list.c:331:25: warning: variable 'ctx' set but not used [-Wunused-but-set-variable]
mm-iface-modem-messaging.c:1210:21: warning: variable 'storage_ctx' set but not used [-Wunused-but-set-variable]
huawei/mm-plugin-huawei.c:183:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
ublox/mm-plugin-ublox.c:161:24: warning: variable 'response' set but not used [-Wunused-but-set-variable]
ublox/mm-plugin-ublox.c:159:24: warning: variable 'ctx' set but not used [-Wunused-but-set-variable]
icera/mm-modem-helpers-icera.c:218:25: warning: variable 'first_free' set but not used [-Wunused-but-set-variable]
novatel/mm-common-novatel.c:50:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
---
 plugins/huawei/mm-plugin-huawei.c      | 3 +--
 plugins/icera/mm-modem-helpers-icera.c | 4 ++--
 plugins/novatel/mm-common-novatel.c    | 3 +--
 plugins/ublox/mm-plugin-ublox.c        | 5 +----
 src/mm-base-call.c                     | 6 ++----
 src/mm-base-sms.c                      | 3 +--
 src/mm-iface-modem-messaging.c         | 2 --
 src/mm-sms-list.c                      | 5 -----
 8 files changed, 8 insertions(+), 23 deletions(-)
Comment 1 Aleksander Morgado 2018-04-24 16:14:02 UTC
Thanks, pushed to git master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.