Attachment 1738 Details for Bug 2361 – patch from Mesa CVS to fix issue

[patch] patch from Mesa CVS to fix issue

rad_ioctl.diff (text/plain), 1.21 KB, created by Dave Airlie on 2005-01-23 15:09:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Airlie

Created: 2005-01-23 15:09:39 UTC

Size: 1.21 KB

patch

obsolete

>===================================================================
>RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/radeon/radeon_ioctl.c,v
>retrieving revision 1.20
>retrieving revision 1.21
>diff -u -r1.20 -r1.21
>--- radeon_ioctl.c	2005/01/23 06:27:08	1.20
>+++ radeon_ioctl.c	2005/01/23 22:09:30	1.21
>@@ -179,8 +179,7 @@
>       rmesa->save_on_next_emit = GL_FALSE;
>    }
> 
>-   if (!rmesa->hw.is_dirty && !rmesa->hw.all_dirty)
>-      return;
>+   /* this code used to return here but now it emits zbs */
> 
>    /* To avoid going across the entire set of states multiple times, just check
>     * for enough space for the case of emitting all state, and inline the
>@@ -189,6 +188,12 @@
>    radeonEnsureCmdBufSpace(rmesa, rmesa->hw.max_state_size);
>    dest = rmesa->store.cmd_buf + rmesa->store.cmd_used;
> 
>+   /* We always always emit zbs, this is due to a bug found by keithw in
>+      the hardware and rediscovered after Erics changes by me.
>+      if you ever touch this code make sure you emit zbs otherwise
>+      you get tcl lockups on at least M7/7500 class of chips - airlied */
>+   rmesa->hw.zbs.dirty=1;
>+
>    if (RADEON_DEBUG & DEBUG_STATE) {
>       foreach(atom, &rmesa->hw.atomlist) {
> 	 if (atom->dirty || rmesa->hw.all_dirty) {

Actions: View | Splinter Review

Attachments on bug 2361: 1738 | 1739

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.