Attachment 26656 Details for Bug 22189 – please try the patch against latest driver, thanks

[patch] please try the patch against latest driver, thanks

0001-hdmi-detect.patch (text/plain), 1.44 KB, created by MaLing on 2009-06-10 22:53:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: MaLing

Created: 2009-06-10 22:53:13 UTC

Size: 1.44 KB

patch

obsolete

>Subject: [PATCH] Set hot plug interrupt to detect HDMI output
>
>We detect HDMI output connection status by writing to HOT Plug Interrupt
>Detect Enable bit in PORT_HOTPLUG_EN. The behavior will generate an specified
>interrupt, which is caught by audio driver, but during one detection driver
>set all Detect Enable bits of HDMIB, HDMIC and HDMID, which generate wrong
>interrupt signals for current output, according to the signals audio driver
>misunderstand device status. The patch intends to handle corresponding output
>precisely.
>
>It fixed fredesktop bug #21371
>
>Signed-off-by: Ma Ling <ling.ma@intel.com>
>---
> src/i830_hdmi.c |   18 +++++++++++++-----
> 1 files changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/src/i830_hdmi.c b/src/i830_hdmi.c
>index 0abb151..63fc6dc 100644
>--- a/src/i830_hdmi.c
>+++ b/src/i830_hdmi.c
>@@ -166,14 +166,22 @@ i830_hdmi_detect(xf86OutputPtr output)
> 
>     temp = INREG(PORT_HOTPLUG_EN);
> 
>-    OUTREG(PORT_HOTPLUG_EN,
>-	   temp |
>-	   HDMIB_HOTPLUG_INT_EN |
>-	   HDMIC_HOTPLUG_INT_EN |
>-	   HDMID_HOTPLUG_INT_EN);
>+    switch (dev_priv->output_reg) {
>+    case SDVOB:
>+	temp |= HDMIB_HOTPLUG_INT_EN;
>+	break;
>+    case SDVOC:
>+	temp |= HDMIC_HOTPLUG_INT_EN;
>+	break;
>+    default:
>+	return XF86OutputStatusUnknown;
>+    }
>+
>+    OUTREG(PORT_HOTPLUG_EN, temp);
> 
>     POSTING_READ(PORT_HOTPLUG_EN);
> 
>+    i830WaitForVblank(pScrn);
>     switch (dev_priv->output_reg) {
>     case SDVOB:
> 	bit = HDMIB_HOTPLUG_INT_STATUS;
>-- 
>1.5.4.4
>

Actions: View | Splinter Review

Attachments on bug 22189: 26607 | 26608 | 26609 | 26610 | 26656 | 26664 | 26760

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.