Attachment 33194 Details for Bug 22936 – Increase fb alignment to 64k

[patch] Increase fb alignment to 64k

0001-drm-i915-Increase-fb-alignment-to-64k.patch (text/plain), 1.31 KB, created by Chris Wilson on 2010-02-09 06:16:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-02-09 06:16:33 UTC

Size: 1.31 KB

patch

obsolete

>From 4601d126902731c795e5066ced8a8e7c3870e80a Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Tue, 9 Feb 2010 14:08:34 +0000
>Subject: [PATCH] drm/i915: Increase fb alignment to 64k
>
>An untiled framebuffer must be aligned to 64k. This is normally handled
>by intel_pin_and_fence_fb_obj(), but the intelfb_create() likes to be
>different and do the pinning itself. However, it aligns the buffer
>object incorrectly for pre-i965 chipsets causing a PGTBL_ERR when it is
>installed onto the output.
>
>Fixes:
>  KMS error message while initializing modesetting -
>  render error detected: EIR: 0x10 [i915]
>  http://bugs.freedesktop.org/show_bug.cgi?id=22936
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: stable@kernel.org
>---
> drivers/gpu/drm/i915/intel_fb.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
>index 371d753..aaabbcb 100644
>--- a/drivers/gpu/drm/i915/intel_fb.c
>+++ b/drivers/gpu/drm/i915/intel_fb.c
>@@ -148,7 +148,7 @@ static int intelfb_create(struct drm_device *dev, uint32_t fb_width,
> 
> 	mutex_lock(&dev->struct_mutex);
> 
>-	ret = i915_gem_object_pin(fbo, PAGE_SIZE);
>+	ret = i915_gem_object_pin(fbo, 64*1024);
> 	if (ret) {
> 		DRM_ERROR("failed to pin fb: %d\n", ret);
> 		goto out_unref;
>-- 
>1.6.6.1
>

Actions: View | Splinter Review

Attachments on bug 22936: 32939 | 33194

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.