Attachment 37142 Details for Bug 29120 – patch

[patch] patch

get-clip-report-failures.patch (text/plain), 1.08 KB, created by Karl Tomlinson on 2010-07-16 15:51:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Karl Tomlinson

Created: 2010-07-16 15:51:34 UTC

Size: 1.08 KB

patch

obsolete

>commit 4f15556481daa44eff5f0460134a9a55f46ae74b
>Author: Karl Tomlinson <karlt+@karlt.net>
>Date:   Sat Jul 17 10:47:42 2010 +1200
>
>    test: return CAIRO_TEST_FAILURE from get-clip preamble on failure
>    
>    https://bugs.freedesktop.org/show_bug.cgi?id=29120
>
>diff --git a/test/get-clip.c b/test/get-clip.c
>index 1847229..9d6e796 100644
>--- a/test/get-clip.c
>+++ b/test/get-clip.c
>@@ -98,6 +98,7 @@ preamble (cairo_test_context_t *ctx)
>     cairo_t                *cr;
>     cairo_rectangle_list_t *rectangle_list;
>     const char             *phase;
>+    cairo_bool_t            completed = 0;
>     cairo_status_t          status;
> 
>     surface = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, SIZE, SIZE);
>@@ -224,11 +225,15 @@ preamble (cairo_test_context_t *ctx)
>     if (! check_unrepresentable (ctx, phase, rectangle_list))
> 	goto FAIL;
> 
>+    completed = 1;
> FAIL:
>     cairo_rectangle_list_destroy (rectangle_list);
>     status = cairo_status (cr);
>     cairo_destroy (cr);
> 
>+    if (!completed)
>+        return CAIRO_TEST_FAILURE;
>+
>     return cairo_test_status_from_status (ctx, status);
> }
>

Actions: View | Splinter Review

Attachments on bug 29120: 37142

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.