Bug 29120 - test/get-clip.c does not report failures
Summary: test/get-clip.c does not report failures
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.9.13
Hardware: Other All
: medium normal
Assignee: Karl Tomlinson
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on: 29121 29122
Blocks:
  Show dependency tree / graph
 
Reported: 2010-07-16 14:58 UTC by Karl Tomlinson
Modified: 2010-08-08 08:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch (1.08 KB, patch)
2010-07-16 15:51 UTC, Karl Tomlinson 		Details | Splinter Review
View All

Description Karl Tomlinson 2010-07-16 14:58:47 UTC 
Since
http://cgit.freedesktop.org/cairo/commit/?id=336eddfdbb31865e3669ceb775089c63ce1db27f
get-clip.c has not returned CAIRO_TEST_FAILURE for failures in its own
explicit tests.
(I'll attach a patch shortly.)
Comment 1 Karl Tomlinson 2010-07-16 15:51:34 UTC 
Created attachment 37142 [details] [review]
patch
Comment 2 Karl Tomlinson 2010-07-16 15:53:07 UTC 
To make the test pass the patches in bug 29121 and bug 29122 will be needed.
Comment 3 Chris Wilson 2010-07-17 02:29:30 UTC 
Karl, do you mind replacing these patches with ones generated by git format-patch?
Comment 4 Chris Wilson 2010-07-17 03:33:47 UTC 
commit 6a5115901381fe9c81a8a311e267c2a00e2a1d04
Author: Karl Tomlinson <karlt+@karlt.net>
Date:   Sat Jul 17 10:47:42 2010 +1200

    test: return CAIRO_TEST_FAILURE from get-clip preamble on failure
    
    https://bugs.freedesktop.org/show_bug.cgi?id=29120

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.