Attachment 38560 Details for Bug 29984 – Patch to invalidate drawable buffers immediately after binding.

[patch] Patch to invalidate drawable buffers immediately after binding.

invalidate-on-bind.patch (text/plain), 1.48 KB, created by Kristian Høgsberg on 2010-09-08 08:41:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kristian Høgsberg

Created: 2010-09-08 08:41:01 UTC

Size: 1.48 KB

patch

obsolete

>diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
>index e38a40c..ea48063 100644
>--- a/src/glx/dri2_glx.c
>+++ b/src/glx/dri2_glx.c
>@@ -136,6 +136,7 @@ dri2_bind_context(struct glx_context *context, struct glx_context *old,
>    struct dri2_context *pcp = (struct dri2_context *) context;
>    struct dri2_screen *psc = (struct dri2_screen *) pcp->base.psc;
>    struct dri2_drawable *pdraw, *pread;
>+   struct dri2_display *pdp;
> 
>    pdraw = (struct dri2_drawable *) driFetchDrawable(context, draw);
>    pread = (struct dri2_drawable *) driFetchDrawable(context, read);
>@@ -143,11 +144,21 @@ dri2_bind_context(struct glx_context *context, struct glx_context *old,
>    if (pdraw == NULL || pread == NULL)
>       return GLXBadDrawable;
> 
>-   if ((*psc->core->bindContext) (pcp->driContext,
>-				  pdraw->driDrawable, pread->driDrawable))
>-      return Success;
>+   if (!(*psc->core->bindContext) (pcp->driContext,
>+				   pdraw->driDrawable, pread->driDrawable))
>+      return GLXBadContext;
>+
>+   /* If the server doesn't send invalidate events, we may miss a
>+    * resize before the rendering starts.  Invalidate the buffers now
>+    * so the driver will recheck before rendering starts. */
>+   pdp = (struct dri2_display *) psc->base.display;
>+   if (!pdp->invalidateAvailable) {
>+      dri2InvalidateBuffers(psc->base.dpy, pdraw->base.xDrawable);
>+      if (pread != pdraw)
>+	 dri2InvalidateBuffers(psc->base.dpy, pread->base.xDrawable);
>+   }
> 
>-   return GLXBadContext;
>+   return Success;
> }
> 
> static void

Actions: View | Splinter Review

Attachments on bug 29984: 38391 | 38560

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.