Attachment 43337 Details for Bug 34251 – Remove unused member variable.

[patch] Remove unused member variable.

0001-Remove-unused-member-variable.patch (text/plain), 1.98 KB, created by Stef Walter on 2011-02-14 02:24:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stef Walter

Created: 2011-02-14 02:24:15 UTC

Size: 1.98 KB

patch

obsolete

>From 4be8f1526a05958d56656306cb97b00d9f4b9c6d Mon Sep 17 00:00:00 2001
>From: Stef Walter <stefw@collabora.co.uk>
>Date: Sun, 13 Feb 2011 16:00:57 +0100
>Subject: [PATCH 1/2] Remove unused member variable.
>
>SalutImManagerPrivate::pending_connections
>---
> src/salut-im-manager.c |   24 ------------------------
> 1 files changed, 0 insertions(+), 24 deletions(-)
>
>diff --git a/src/salut-im-manager.c b/src/salut-im-manager.c
>index 9662f7c..db42b1e 100644
>--- a/src/salut-im-manager.c
>+++ b/src/salut-im-manager.c
>@@ -73,7 +73,6 @@ struct _SalutImManagerPrivate
>   SalutConnection *connection;
>   SalutXmppConnectionManager *xmpp_connection_manager;
>   GHashTable *channels;
>-  GHashTable *pending_connections;
>   gulong status_changed_id;
>   gboolean dispose_has_run;
> };
>@@ -83,29 +82,12 @@ struct _SalutImManagerPrivate
>                                 SalutImManagerPrivate))
> 
> static void
>-contact_list_destroy (gpointer data)
>-{
>-  GList *list = (GList *) data;
>-  GList *t = list;
>-  while (t != NULL)
>-    {
>-      SalutContact *contact;
>-      contact= SALUT_CONTACT (t->data);
>-      g_object_unref (contact);
>-      t = g_list_next (t);
>-    }
>-  g_list_free (list);
>-}
>-
>-static void
> salut_im_manager_init (SalutImManager *obj)
> {
>   SalutImManagerPrivate *priv = SALUT_IM_MANAGER_GET_PRIVATE (obj);
>   /* allocate any data required by the object here */
>   priv->channels = g_hash_table_new_full (g_direct_hash, g_direct_equal,
>       NULL, g_object_unref);
>-  priv->pending_connections = g_hash_table_new_full (g_direct_hash,
>-      g_direct_equal, g_object_unref, contact_list_destroy);
> }
> 
> static gboolean
>@@ -347,12 +329,6 @@ salut_im_manager_dispose (GObject *object)
> 
>   salut_im_factory_close_all (self);
> 
>-  if (priv->pending_connections)
>-    {
>-      g_hash_table_destroy (priv->pending_connections);
>-      priv->pending_connections = NULL;
>-    }
>-
>   if (G_OBJECT_CLASS (salut_im_manager_parent_class)->dispose)
>     G_OBJECT_CLASS (salut_im_manager_parent_class)->dispose (object);
> }
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 34251: 43337 | 43338

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.