Bug 34251 - Cleanup of unused code and comments
Summary: Cleanup of unused code and comments
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 02:23 UTC by Stef Walter
Modified: 2011-02-16 01:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Remove unused member variable. (1.98 KB, patch)
2011-02-14 02:24 UTC, Stef Walter 		Details | Splinter Review
Cleanup comments that no longer match source. (4.00 KB, patch)
2011-02-14 02:24 UTC, Stef Walter 		Details | Splinter Review
View All

Description Stef Walter 2011-02-14 02:23:27 UTC 
Some cleanup patches for unused code and comments.


 * Cleanup some comments that no longer match source.
 * Remove unused member variable: SalutImManagerPrivate::pending_connections
Comment 1 Stef Walter 2011-02-14 02:24:15 UTC 
Created attachment 43337 [details] [review]
Remove unused member variable.
Comment 2 Stef Walter 2011-02-14 02:24:48 UTC 
Created attachment 43338 [details] [review]
Cleanup comments that no longer match source.
Comment 3 Jonny Lamb 2011-02-14 03:04:39 UTC 
Looks good.
Comment 4 Stef Walter 2011-02-14 03:07:31 UTC 
Here's a branch with these patches:

http://git.collabora.co.uk/?p=user/stefw/telepathy-salut.git;a=shortlog;h=refs/heads/salut-nitpicks
Comment 5 Stef Walter 2011-02-14 03:26:34 UTC 
Merged with master.
Comment 6 Stef Walter 2011-02-15 23:52:50 UTC 
I didn't notice that the push failed. I need to get in a few more patches before I get repository access. Anyone want to merge and push this for me?
Comment 7 Jonny Lamb 2011-02-16 00:32:37 UTC 
Agh, no you asked me to merge this for you which I completely forgot to do! I just merged it now! Sorry for this!
Comment 8 Stef Walter 2011-02-16 01:13:52 UTC 
No worries. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.