Attachment 46378 Details for Bug 34796 – idletest: return an empty RPL_WHOISCHANNELS in response to WHOIS

[patch] idletest: return an empty RPL_WHOISCHANNELS in response to WHOIS

0002-idletest-return-an-empty-RPL_WHOISCHANNELS-in-respon.patch (text/plain), 1.54 KB, created by Debarshi Ray on 2011-05-05 16:12:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Debarshi Ray

Created: 2011-05-05 16:12:45 UTC

Size: 1.54 KB

patch

obsolete

>From 3999273cdc25220d4614e2b535193dbeeab26d01 Mon Sep 17 00:00:00 2001
>From: Debarshi Ray <rishi@gnu.org>
>Date: Fri, 6 May 2011 02:05:46 +0300
>Subject: [PATCH 2/3] idletest: return an empty RPL_WHOISCHANNELS in response
> to WHOIS
>
>RFC 2812 defines RPL_WHOISCHANNELS as:
>"<nick> :*( ( "@" / "+" ) <channel> " " )"
>Therefore, there is the possibility of an empty message even though
>preliminary testing with some IRC daemons (eg., Freenode, GIMPNet and
>IRCNet) did not reveal such a scenario. Nevertheless to maintain
>strict compliance with the RFC we should test for this as well.
>
>Fixes: https://bugs.freedesktop.org/34796
>---
> tests/twisted/idletest.py |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/tests/twisted/idletest.py b/tests/twisted/idletest.py
>index 9785413..9136cbc 100644
>--- a/tests/twisted/idletest.py
>+++ b/tests/twisted/idletest.py
>@@ -80,6 +80,7 @@ class BaseIRCServer(irc.IRC):
>         self.sendMessage('311', self.nick, self.nick, self.user, 'idle.test.client', '*', ':%s' % self.real_name, prefix='idle.test.server')
>         if self.rooms:
>             self.sendMessage('319', self.nick, self.nick, ':%s' % ' '.join(self.rooms), prefix='idle.test.server')
>+        self.sendMessage('319', self.nick, self.nick, ':', prefix='idle.test.server')
>         self.sendMessage('312', self.nick, self.nick, 'idle.test.server', ':Idle Test Server', prefix='idle.test.server')
>         if self.secure:
>             self.sendMessage('671', self.nick, self.nick, ':is using a secure connection', prefix='idle.test.server')
>-- 
>1.7.4.4
>

Actions: View | Splinter Review

Attachments on bug 34796: 43889 | 43906 | 43927 | 44043 | 44074 | 44075 | 44566 | 44584 | 44601 | 44695 | 44696 | 45013 | 45989 | 46064 | 46065 | 46066 | 46067 | 46158 | 46160 | 46161 | 46248 | 46377 | 46378 | 46379 | 46403 | 46405 | 46501 | 46523 | 46524 | 46525 | 46610 | 46612 | 46613 | 46614 | 46615

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.