Attachment 48117 Details for Bug 36917 – [PATCH] r600g: fix LIT to handle src==dst properly

[patch] [PATCH] r600g: fix LIT to handle src==dst properly

0003-r600g-fix-LIT-implementation-on-evergreen.patch (text/plain), 1.35 KB, created by Vadim Girlin on 2011-06-17 13:13:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vadim Girlin

Created: 2011-06-17 13:13:03 UTC

Size: 1.35 KB

patch

obsolete

>From 9050053313c6ff270f990068d4df37b3d69b9e15 Mon Sep 17 00:00:00 2001
>From: Vadim Girlin <vadimgirlin@gmail.com>
>Date: Fri, 17 Jun 2011 16:05:55 +0400
>Subject: [PATCH 3/3] r600g: fix LIT to handle src==dst properly
>
>Current LIT implementation uses dst components for storing temp
>results, possibly overwriting still needed values (depends on the
>swizzles).
>This patch uses temp reg for one of such cases (found in etqw) and
>fixes "LIT R.z, R.xyzz".
>
>Tested on evergreen. Fixes some etqw-demo rendering glitches when 
>"Lighting" is set to "High" in the settings.
>
>Signed-off-by: Vadim Girlin <vadimgirlin@gmail.com>
>---
> src/gallium/drivers/r600/r600_shader.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c
>index 0995dd5..0268108 100644
>--- a/src/gallium/drivers/r600/r600_shader.c
>+++ b/src/gallium/drivers/r600/r600_shader.c
>@@ -1366,7 +1366,9 @@ static int tgsi_lit(struct r600_shader_ctx *ctx)
> 			memset(&alu, 0, sizeof(struct r600_bc_alu));
> 			alu.inst = CTX_INST(V_SQ_ALU_WORD1_OP2_SQ_OP2_INST_LOG_CLAMPED);
> 			r600_bc_src(&alu.src[0], &ctx->src[0], 1);
>-			tgsi_dst(ctx, &inst->Dst[0], 2, &alu.dst);
>+			alu.dst.sel = ctx->temp_reg;
>+			alu.dst.chan = 2;
>+			alu.dst.write = 1;
> 			alu.last = 1;
> 			r = r600_bc_add_alu(ctx->bc, &alu);
> 			if (r)
>-- 
>1.7.5.4
>

Actions: View | Splinter Review

Attachments on bug 36917: 46406 | 47875 | 47876 | 48072 | 48117

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.