Attachment 49073 Details for Bug 38142 – Add a comment explaining why we cannot let make TpContact subclasses yet

[patch] Add a comment explaining why we cannot let make TpContact subclasses yet

Add-a-comment-explaining-why-we-cannot-let-make-Tp.patch (text/plain), 1.04 KB, created by Guillaume Desmottes on 2011-07-14 02:43:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2011-07-14 02:43:14 UTC

Size: 1.04 KB

patch

obsolete

>From e601cd16ce0594a8e3386b00b50b8352922f5f10 Mon Sep 17 00:00:00 2001
>From: Xavier Claessens <xclaesse@gmail.com>
>Date: Thu, 14 Jul 2011 09:21:36 +0200
>Subject: [PATCH] Add a comment explaining why we cannot let make TpContact subclasses yet
>
>---
> telepathy-glib/contact.c |    9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
>diff --git a/telepathy-glib/contact.c b/telepathy-glib/contact.c
>index 8d2bae4..612b08d 100644
>--- a/telepathy-glib/contact.c
>+++ b/telepathy-glib/contact.c
>@@ -1352,6 +1352,15 @@ _tp_contact_new (TpConnection *connection,
>   return self;
> }
> 
>+/* FIXME: Ideally this should be replaced with
>+ *
>+ * tp_simple_client_factory_dup_contact (tp_proxy_get_factory (connection),
>+ *     handle, identifier);
>+ *
>+ * but we cannot assert CM has immortal handles (yet). That means we cannot
>+ * guarantee that all TpContact objects are created through the factory and so
>+ * let it make TpContact subclasses.
>+ */
> static TpContact *
> tp_contact_ensure (TpConnection *connection,
>                    TpHandle handle)
>-- 
>1.7.4.1

Actions: View | Splinter Review

Attachments on bug 38142: 47808 | 49036 | 49037 | 49070 | 49071 | 49072 | 49073 | 49077 | 49078 | 49079 | 49080 | 49081 | 49082

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.