Attachment 49955 Details for Bug 39231 – Enable more compiler warnings by default

[patch] Enable more compiler warnings by default

0001-Enable-more-compiler-warnings-by-default.patch (text/plain), 2.50 KB, created by Simon McVittie on 2011-08-05 06:12:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-08-05 06:12:28 UTC

Size: 2.50 KB

patch

obsolete

>From 51d33b784ee61176e699b630eb1dd7acd986b726 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 5 Aug 2011 13:55:48 +0100
>Subject: [PATCH] Enable more compiler warnings by default
>
>---
> configure.ac |   26 +++++++++++++++++++++-----
> 1 files changed, 21 insertions(+), 5 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 10575df..5512233 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -224,6 +224,7 @@ fi
> 
> if test x$enable_asserts = xno; then
>     AC_DEFINE(DBUS_DISABLE_ASSERT,1,[Disable assertion checking])
>+    DISABLE_UNUSED_WARNINGS="unused-label"
>     R_DYNAMIC_LDFLAG=""
> else
>     # -rdynamic is needed for glibc's backtrace_symbols to work.
>@@ -241,6 +242,7 @@ AC_SUBST(R_DYNAMIC_LDFLAG)
> if test x$enable_checks = xno; then
>     AC_DEFINE(DBUS_DISABLE_CHECKS,1,[Disable public API sanity checking])
>     AC_DEFINE(G_DISABLE_CHECKS,1,[Disable GLib public API sanity checking])
>+    DISABLE_UNUSED_WARNINGS="unused-label"
> fi
> 
> if test x$enable_userdb_cache = xyes; then
>@@ -1203,8 +1205,9 @@ TP_COMPILER_WARNINGS([WARNING_CFLAGS],
>   dnl Override with --enable-Werror or --disable-Werror
>   [test x$dbus_win != xyes -a x$dbus_cygwin != xyes -a x$USE_MAINTAINER_MODE = xyes],
> 
>-  dnl enable these warnings if possible:
>+  dnl Enable these warnings if possible:
>   [all \
>+   extra \
>    char-subscripts \
>    missing-declarations \
>    missing-prototypes \
>@@ -1216,12 +1219,25 @@ TP_COMPILER_WARNINGS([WARNING_CFLAGS],
>    declaration-after-statement \
>   ],
> 
>-  dnl disable these warnings if possible, make them non-fatal if possible,
>-  dnl and don't enable -Werror unless we succeeded:
>-  dnl (unused is by design, sign-compare and pointer-sign are fd.o #17433)
>-  [unused \
>+  dnl Disable these warnings if possible, make them non-fatal if possible,
>+  dnl and don't enable -Werror unless we succeeded.
>+  dnl
>+  dnl Intentional:
>+  dnl - $DISABLE_UNUSED_WARNINGS disables unused-label warnings if not
>+  dnl   checking or not asserting
>+  dnl - missing field initializers being 0 is a C feature, not a bug
>+  dnl - unused-parameter is to make writing callbacks less annoying
>+  dnl
>+  dnl To be fixed one day:
>+  dnl - sign-compare and pointer-sign are workarounds for fd.o #17433
>+  dnl - type-limits is probably a bug too, but having the rest of -Wextra
>+  dnl   is better than nothing
>+  [$DISABLE_UNUSED_WARNINGS \
>+   missing-field-initializers \
>+   unused-parameter \
>    sign-compare \
>    pointer-sign \
>+   type-limits \
>   ])
> 
> if test "x$GCC" = "xyes"; then
>-- 
>1.7.5.4
>

Actions: View | Splinter Review

Attachments on bug 39231: 49955

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.