dbus can't be compiled with -Werror=unused, even in a "normal" configuration. We should fix the warnings so we can turn on -Werror=unused all the time, because unused variables can indicate genuine bugs, like Bug #39230.
Here are patches. I'll spare you the attachment bugspam, because there are 11 so far.
Bug #39230 and Bug #38005 also produce warnings, which are not addressed here.
All eleven patches—up to and including “_dbus_lookup_session_address_launchd: don't define if not used”—look fine to me.
Thanks, merged for 1.5.8. I'll leave this bug open, because there are more unused variables if you either:
* build on master, or
* don't assert, or
* don't return_if_fail
Branch more-unused-39231 fixes more warnings.
Eventually, I'd like to apply the patch that I'm about to attach, to make unused stuff fatal; but it's blocked by Bug #39230 as well as this one.
Created attachment 49955 [details] [review]
Enable more compiler warnings by default
Blocked by this bug and Bug #39230. When applying it, I'll also have to check that no more unused things have been introduced by then.
This enables -Wextra, except for -Wunused-parameter (intentional), -Wmissing-field-initializers (intentional), -Wtype-limits (probably a bug, we can open one later), and -Wunused-label if either assertions or checks are disabled.
(Rationale for -Wunused-label: unused labels rarely cause dead code, and at least one place in libdbus jumps to a label only if return_if_fail-style checks are enabled.)
more-unused-39231 looks fine, as does the attached patch to enable more warnings (in principle).
Fixed in git for 1.5.8. Unused variables, etc., are now considered to be an error.