Attachment 54436 Details for Bug 41734 – correct patch to remove the duplicated contact

[patch] correct patch to remove the duplicated contact

0001-Call.Content.I.Media-Remove-duplicated-Remote-Contac.patch (text/plain), 2.86 KB, created by Olivier Crête on 2011-12-14 13:24:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Crête

Created: 2011-12-14 13:24:43 UTC

Size: 2.86 KB

patch

obsolete

>From a76c15960deed9eaab21604830a032e90cf26b53 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Olivier=20Cr=C3=AAte?= <olivier.crete@collabora.com>
>Date: Wed, 14 Dec 2011 16:06:15 -0500
>Subject: [PATCH] Call.Content.I.Media: Remove duplicated Remote Contact
>
>The Remote contact object already present inside the MediaDescription objects.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=41734
>---
> spec/Call_Content_Interface_Media.xml |   23 +----------------------
> 1 files changed, 1 insertions(+), 22 deletions(-)
>
>diff --git a/spec/Call_Content_Interface_Media.xml b/spec/Call_Content_Interface_Media.xml
>index ca5ed36..5abdea2 100644
>--- a/spec/Call_Content_Interface_Media.xml
>+++ b/spec/Call_Content_Interface_Media.xml
>@@ -225,11 +225,6 @@
>           >MediaDescription</tp:dbus-ref>
>         </tp:docstring>
>       </tp:member>
>-      <tp:member name="Remote_Contact" type="u" tp:type="Contact_Handle">
>-        <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>-          The contact handle that this description applies to.
>-        </tp:docstring>
>-      </tp:member>
>       <tp:member name="Properties" type="a{sv}"
>            tp:type="Media_Description_Properties">
>         <tp:docstring>
>@@ -256,15 +251,6 @@
>         Otherwise, only parameters which strictly describe the media being sent
>         can be changed.
>       </tp:docstring>
>-      <arg name="Remote_Contact" type="u" tp:type="Handle" direction="in">
>-        <tp:docstring>
>-          The remote contact that this description should be negotiated with
>-          (or 0 to mean "negotiate this with everyone"). Note that encoding
>-          the same video multiple times is often needlessly expensive, so
>-          differences in MediaDescriptions negotiated with different parties
>-          in the call should be limited to payloading parameters if possible.
>-        </tp:docstring>
>-      </arg>
>       <arg name="MediaDescription" direction="in" type="a{sv}"
>            tp:type="Media_Description_Properties">
>         <tp:docstring>
>@@ -383,13 +369,6 @@
>         </p>
>       </tp:docstring>
> 
>-      <arg name="Remote_Contact" type="u" tp:type="Handle">
>-        <tp:docstring>
>-          The remote contact that this description was negotiated with
>-          (or 0 to mean "negotiated with everyone").
>-        </tp:docstring>
>-      </arg>
>-
>       <arg name="Updated_Media_Description" type="a{sv}"
>         tp:type="Media_Description_Properties">
>         <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>@@ -440,7 +419,7 @@
> 
>     <property name="MediaDescriptionOffer"
>         tp:name-for-bindings="Media_Description_Offer"
>-      type="(oua{sv})" tp:type="Media_Description_Offer" access="read">
>+      type="(oa{sv})" tp:type="Media_Description_Offer" access="read">
>       <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>         <p>The object path to the current
>           <tp:dbus-ref namespace="ofdT.Call1.Content"
>-- 
>1.7.7.4
>

Actions: View | Splinter Review

Attachments on bug 41734: 54431 | 54436 | 54756

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.