In Call1.Content.Interface.Media, there is a type called Media_Description_Offer which contains a RemoteContact (a handle) and a map of the properties of Call1.Content.MediaDescription which alse contains a member called RemoteContact which is also a handle.. Is it duplicated? If so, then we should get rid of the Handle in the signals in Call1.Content.Interface.Media I guess. Let's fix this now before I finish the Call1 port of tp-fs.
Created attachment 54431 [details] [review] spec patch Here is a patch that just removes the extra remote contact handle from the signals and methods in Content.I.Media. Please discuss.
Created attachment 54436 [details] [review] correct patch to remove the duplicated contact Again, put the right patch
This is cosmetical, but why not.
Merge away.
Merged ommit 725a680a48a88d1befbdf332f6ea61a8cf4743d3 Author: Olivier Crête <olivier.crete@collabora.com> Date: Wed Dec 14 16:06:15 2011 -0500 Call.Content.I.Media: Remove duplicated Remote Contact The Remote contact object already present inside the MediaDescription object https://bugs.freedesktop.org/show_bug.cgi?id=41734
Created attachment 54756 [details] [review] last one oops, I forgot one..
Is this going to disrupt finalizing Call? If not, r+.
Merged, was last diff between tp-spec and tp-glib' spec, except for the undraft.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.