Attachment 57321 Details for Bug 46344 – 0001-build-Do-not-hardcode-WError.patch

[patch] 0001-build-Do-not-hardcode-WError.patch

0001-build-Do-not-hardcode-WError.patch (text/plain), 1.34 KB, created by Robert Staudinger on 2012-02-20 07:05:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Robert Staudinger

Created: 2012-02-20 07:05:23 UTC

Size: 1.34 KB

patch

obsolete

>From a85ec0a7c278d1902541fc69be3f92da57277edb Mon Sep 17 00:00:00 2001
>From: Rob Staudinger <robsta@linux.intel.com>
>Date: Mon, 20 Feb 2012 16:01:22 +0100
>Subject: [PATCH] build: Do not hardcode -WError
>
>Add -WError and other zealous warnings only when configured with
>--enable-debug, so to prevent the buildbot from raising a red alert
>as a response to venial sins.
>
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=46344
>---
> configure.ac |    9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 0c79cbd..bd70db8 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -137,17 +137,16 @@ AC_ARG_ENABLE(debug,
> 
> AC_MSG_CHECKING(for DEBUG mode)
> if test "$enable_debug" = "yes"; then
>-	CFLAGS="$CFLAGS -g -O0 -Werror -DG_DISABLE_DEPRECATED"
>+	CFLAGS="$CFLAGS -g -O0 -Werror -Wall -Wextra -Wno-missing-field-initializers \
>+	        -Wno-unused-parameter -Wdeclaration-after-statement -Wshadow \
>+	        -Wmissing-prototypes -Wmissing-declarations \
>+	        -DG_DISABLE_DEPRECATED"
> 	AC_DEFINE_UNQUOTED(_DEBUG, 1, [In debug mode])
> 	AC_MSG_RESULT(yes)
> else
> 	AC_MSG_RESULT(no)
> fi
> 
>-CFLAGS="$CFLAGS -Werror -Wall -Wextra -Wno-missing-field-initializers \
>-	-Wno-unused-parameter -Wdeclaration-after-statement -Wshadow \
>-	-Wmissing-prototypes -Wmissing-declarations"
>-
> AC_SUBST(CFLAGS)
> 
> AC_OUTPUT([
>-- 
>1.7.7.6
>

Actions: View | Splinter Review

Attachments on bug 46344: 57321

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.