Bug 46344 - Hardcoded WError -- no cookie
Summary: Hardcoded WError -- no cookie
Status: NEW
Alias: None
Product: Ytstenut
Classification: Unclassified
Component: plugins (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Robert Staudinger
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-20 06:53 UTC by Robert Staudinger
Modified: 2012-02-20 07:05 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
0001-build-Do-not-hardcode-WError.patch (1.34 KB, patch)
2012-02-20 07:05 UTC, Robert Staudinger 		Details | Splinter Review
View All

Description Robert Staudinger 2012-02-20 06:53:05 UTC 
I'm worried that this bit of code will make the buildbot might choke more often than strictly needed because of hardcoded -WError:

CFLAGS="$CFLAGS -Werror -Wall -Wextra -Wno-missing-field-initializers \
	-Wno-unused-parameter -Wdeclaration-after-statement -Wshadow \
	-Wmissing-prototypes -Wmissing-declarations"
Comment 1 Robert Staudinger 2012-02-20 07:05:23 UTC 
Created attachment 57321 [details] [review]
0001-build-Do-not-hardcode-WError.patch

commit a85ec0a7c278d1902541fc69be3f92da57277edb
Author: Rob Staudinger <robsta@linux.intel.com>
Date:   Mon Feb 20 16:01:22 2012 +0100

    build: Do not hardcode -WError
    
    Add -WError and other zealous warnings only when configured with
    --enable-debug, so to prevent the buildbot from raising a red alert
    as a response to venial sins.
    
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=46344

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.