Attachment 57409 Details for Bug 43427 – Maintain fenced gpu access until flushed

[patch] Maintain fenced gpu access until flushed

0001-drm-i915-Maintain-fenced-gpu-access-until-we-flush-t.patch (text/plain), 1.41 KB, created by Chris Wilson on 2012-02-21 10:05:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-02-21 10:05:29 UTC

Size: 1.41 KB

patch

obsolete

>From 7f7483603a77042e7e065ca04eb2d95267623f4c Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Wed, 23 Mar 2011 09:40:00 +0000
>Subject: [PATCH] drm/i915: Maintain fenced gpu access until we flush the
> fence
>
>We only want to mark the transition from unfenced GPU access by an
>execbuffer, so that we are forced to flush any pending writes through
>the fence before updating the register.
>
>In applying this fix for a corruption bug, we do lose the ability to
>detect the earliest end of GPU fenced access, thus disabling the inherent
>optimization.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/i915_gem_execbuffer.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>index 20a4cc5..a07911f 100644
>--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>@@ -911,7 +911,7 @@ i915_gem_execbuffer_move_to_active(struct list_head *objects,
> 
> 		obj->base.read_domains = obj->base.pending_read_domains;
> 		obj->base.write_domain = obj->base.pending_write_domain;
>-		obj->fenced_gpu_access = obj->pending_fenced_gpu_access;
>+		obj->fenced_gpu_access |= obj->pending_fenced_gpu_access;
> 
> 		i915_gem_object_move_to_active(obj, ring, seqno);
> 		if (obj->base.write_domain) {
>-- 
>1.7.9
>

Actions: View | Splinter Review

Attachments on bug 43427: 54019 | 54020 | 54021 | 54023 | 54115 | 54116 | 54117 | 55910 | 56981 | 57123 | 57231 | 57409 | 57711 | 57827 | 58757 | 58782

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.