Attachment 58733 Details for Bug 47558 – Don't segfault if there is no error set

[patch] Don't segfault if there is no error set

Dont-segfault-if-there-is-no-error-set.patch (text/plain), 1.08 KB, created by Emanuele Aina on 2012-03-20 02:29:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emanuele Aina

Created: 2012-03-20 02:29:45 UTC

Size: 1.08 KB

patch

obsolete

>From d1197fffe88f18d1a4a3bdf66bff4c1eee9bb2d6 Mon Sep 17 00:00:00 2001
>From: Emanuele Aina <emanuele.aina@collabora.com>
>Date: Tue, 20 Mar 2012 10:26:42 +0100
>Subject: [PATCH] Don't segfault if there is no error set
>
>https://bugs.freedesktop.org/show_bug.cgi?id=47558
>---
> telepathy-farstream/call-content.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/telepathy-farstream/call-content.c b/telepathy-farstream/call-content.c
>index b4b5146..1d7da9d 100644
>--- a/telepathy-farstream/call-content.c
>+++ b/telepathy-farstream/call-content.c
>@@ -1159,7 +1159,7 @@ got_content_media_properties (TpProxy *proxy, GHashTable *properties,
>       tf_call_content_error (self,
>           TP_CALL_STATE_CHANGE_REASON_MEDIA_ERROR,
>           TP_ERROR_STR_MEDIA_UNSUPPORTED_TYPE,
>-          "Could not create FsSession: %s", myerror->message);
>+          "Could not create FsSession: %s", myerror != NULL ? myerror->message : "(unknown error)");
>       g_simple_async_result_set_from_error (res, myerror);
>       g_simple_async_result_complete (res);
>       g_clear_error (&myerror);
>-- 
>1.7.9.1

Actions: View | Splinter Review

Attachments on bug 47558: 58733

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.