Bug 47558 - Don't segfault on error if there is no GError set
Summary: Don't segfault on error if there is no GError set
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-farstream (show other bugs)
Version: git master
Hardware: All All
: medium normal
Assignee: Olivier Crête
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 02:29 UTC by Emanuele Aina
Modified: 2012-03-20 09:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Don't segfault if there is no error set (1.08 KB, patch)
2012-03-20 02:29 UTC, Emanuele Aina 		Details | Splinter Review
View All

Description Emanuele Aina 2012-03-20 02:29:42 UTC 

    


    


      



        
          Comment 1
        

        
          Emanuele Aina

        

        
        

        
          2012-03-20 02:29:45 UTC
        

      






Created attachment 58733 [details] [review]
Don't segfault if there is no error set

    


    


      



        
          Comment 2
        

        
          Olivier Crête

        

        
        

        
          2012-03-20 06:52:58 UTC
        

      






Do you have a case where no error is set ?

    


    


      



        
          Comment 3
        

        
          Emanuele Aina

        

        
        

        
          2012-03-20 08:13:07 UTC
        

      






I forgot to set the GST_PLUGIN_LOADING_WHITELIST envvar while testing empathy with farstream from git while farsight is installed: this caused a symbol mismatch on FsRtpConference (invalid cast from `FsRtpConference' to `FsConference') and made the empathy call window segfault.

Maybe I should fix the location where the cast is done and throw in a warning saying that the problem might be due to a conflict between Farsight and Farstream.

    


    


      



        
          Comment 4
        

        
          Olivier Crête

        

        
        

        
          2012-03-20 08:18:36 UTC
        

      






Nah, it's fine.. I'll merge the patch.. was just curious to see how you got that error.

    


    


      



        
          Comment 5
        

        
          Olivier Crête

        

        
        

        
          2012-03-20 09:16:35 UTC
        

      






commit 71b46b46da8bfc77cb3574c21b0739dcc444198d
Author: Emanuele Aina <emanuele.aina@collabora.com>
Date:   Tue Mar 20 10:26:42 2012 +0100

    Don't segfault if there is no error set
    
    https://bugs.freedesktop.org/show_bug.cgi?id=47558

    



  






  














    


  Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.