Attachment 61350 Details for Bug 49518 – don't return -ENXIO

[patch] don't return -ENXIO

0001-drm-i915-don-t-return-ENXIO-from-gmbus-xfer.patch (text/plain), 1.16 KB, created by Daniel Vetter on 2012-05-10 04:22:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2012-05-10 04:22:06 UTC

Size: 1.16 KB

patch

obsolete

>From a74da8b699972894ad4d07efbde5b4cfc4bc0f72 Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Thu, 10 May 2012 13:21:57 +0200
>Subject: [PATCH] drm/i915: don't return -ENXIO from gmbus xfer
>
>... too much risk for flaky edid transfers.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49518
>Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/intel_i2c.c |    7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
>index e04255e..0588d8e 100644
>--- a/drivers/gpu/drm/i915/intel_i2c.c
>+++ b/drivers/gpu/drm/i915/intel_i2c.c
>@@ -418,10 +418,11 @@ clear_err:
> 	 * If no ACK is received during the address phase of a transaction,
> 	 * the adapter must report -ENXIO.
> 	 * It is not clear what to return if no ACK is received at other times.
>-	 * So, we always return -ENXIO in all NAK cases, to ensure we send
>-	 * it at least during the one case that is specified.
>+	 *
>+	 * Unfortunately we can't afford false positives in returning -ENXIO,
>+	 * hence never return -ENXIO.
> 	 */
>-	ret = -ENXIO;
>+	ret = i;
> 	goto out;
> 
> timeout:
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 49518: 61064 | 61065 | 61088 | 61089 | 61090 | 61203 | 61204 | 61350 | 61885

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.