Attachment 625 Details for Bug 1042 – Patch to add .PHONY target when using GNU make

[patch] Patch to add .PHONY target when using GNU make

phony-gnu.patch (text/plain), 1.79 KB, created by Kristian Høgsberg on 2004-08-13 07:18:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kristian Høgsberg

Created: 2004-08-13 07:18:54 UTC

Size: 1.79 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>RCS file: /cvs/xorg/xc/ChangeLog,v
>retrieving revision 1.262
>diff -u -p -r1.262 ChangeLog
>--- ChangeLog	13 Aug 2004 12:57:11 -0000	1.262
>+++ ChangeLog	13 Aug 2004 14:09:43 -0000
>@@ -1,5 +1,9 @@
> 2004-08-13  Kristian HÃ¸gsberg  <krh@redhat.com>
> 
>+	* config/cf/Imake.rules:
>+	Add .PHONY target when using GNU make.  This will speed up make in
>+	general, but more importantly fix #1042.
>+
> 	* programs/xterm/*:
> 	Merge in version 195 from upstream xterm
> 	(http://dickey.his.com/xterm). Fixes #855.
>Index: config/cf/Imake.rules
>===================================================================
>RCS file: /cvs/xorg/xc/config/cf/Imake.rules,v
>retrieving revision 1.5
>diff -u -p -r1.5 Imake.rules
>--- config/cf/Imake.rules	26 Jun 2004 16:26:18 -0000	1.5
>+++ config/cf/Imake.rules	13 Aug 2004 14:09:43 -0000
>@@ -3607,3 +3607,21 @@ clean::									@@\
> #ifndef LinkerRuntimeLibraryPathFlag
> # define LinkerRuntimeLibraryPathFlag(path)  /* */
> #endif
>+
>+/* Phony targets - GNU make has a feature to mark a target as phony,
>+ * which means that it wont consider that target to be the name of a
>+ * file.  In general this speeds up make, since it doesn't have to
>+ * look for those files when it sets out to create a phony target.
>+ * However, on cygwin, this is actually required for correct
>+ * operation, since the Win32 filesystems are case insensitive and the
>+ * install target conflicts with the INSTALL file present in some
>+ * (autotooled) directories.
>+ *
>+ * We probably don't need the #ifdef protection, since other make
>+ * implementations would just consider this a normal rules.  Better
>+ * safe than sorry, though.
>+ */
>+#if HasGnuMake
>+.PHONY: all interfaces install install.man install.lib install.sdk \
>+	depend includes clean
>+#endif

Actions: View | Splinter Review

Attachments on bug 1042: 610 | 616 | 625

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.