Bug 1042 - file INSTALL breaks make install on cygwin
Summary: file INSTALL breaks make install on cygwin
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/other (show other bugs)
Version: git
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351
  Show dependency tree / graph
 
Reported: 2004-08-11 12:39 UTC by Alexander Gottwald
Modified: 2007-01-23 17:34 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
proposed patch (552 bytes, patch)
2004-08-11 13:00 UTC, Alexander Gottwald 		no flags Details | Splinter Review
revised patch. (687 bytes, patch)
2004-08-12 01:33 UTC, Alexander Gottwald 		no flags Details | Splinter Review
Patch to add .PHONY target when using GNU make (1.79 KB, patch)
2004-08-13 07:18 UTC, Kristian Høgsberg 		no flags Details | Splinter Review
Show Obsolete (2) View All

Description Alexander Gottwald 2004-08-11 12:39:49 UTC 
because cygwin is not case sensitive the file INSTALL in lib/Xdamage, lib/Xfixes
and lib/Xcomposite will prevent make from properly installing Xdamage.h,
Xcomposite.h and Xfixes.h

Solution is adding .PHONY: install to the makefiles if all supported make
variants understand it or removing the INSTALL files from cvs
Comment 1 Alexander Gottwald 2004-08-11 13:00:28 UTC 
Created attachment 610 [details] [review]
proposed patch

adds .PHONY: install to imake.tmpl

i'm not sure if all supported make variants understand that
Comment 2 Kristian Høgsberg 2004-08-11 13:31:54 UTC 
Wouldn't "any" make that you could use on cygwin support .phony?  Cygwin gives
you GNU make, so wouldn't

  #ifdef CYGWIN
  .phony install
  #endif

be acceptable (if not exactly elegant...)?
Comment 3 Alexander Gottwald 2004-08-12 01:33:47 UTC 
Created attachment 616 [details] [review]
revised patch.

.PHONY: install is wrapped with #ifdef cygwinArchitecture
Comment 4 Kristian Høgsberg 2004-08-13 07:18:54 UTC 
Created attachment 625 [details] [review]
Patch to add .PHONY target when using GNU make

This would belong in Imake.rules, I think.  I changed the patch to always use
phony targets when using GNU make, since it also speeds up make in general. 
Also, I added a list of other targets and a little essay about the .PHONY
target.
Comment 5 Kristian Høgsberg 2004-08-13 10:29:00 UTC 
Patch applied, bug closed.
Comment 6 Kristian Høgsberg 2004-08-13 10:40:35 UTC 
Second try...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.