Attachment 79457 Details for Bug 64694 – Possible fix

[patch] Possible fix

0001-R600-SI-return-undef-instead-of-null-for-skipped-arg.patch (text/plain), 1.28 KB, created by Christian König on 2013-05-17 09:02:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian König

Created: 2013-05-17 09:02:49 UTC

Size: 1.28 KB

patch

obsolete

>From bb46ab13e78c5f6b9721e6027f1c5f9dc39c2864 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>
>Date: Fri, 17 May 2013 11:01:19 +0200
>Subject: [PATCH] R600/SI: return undef instead of null for skipped arguments
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: Christian KÃ¶nig <christian.koenig@amd.com>
>---
> lib/Target/R600/SIISelLowering.cpp |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/Target/R600/SIISelLowering.cpp b/lib/Target/R600/SIISelLowering.cpp
>index 6bd82a5..98ef80f 100644
>--- a/lib/Target/R600/SIISelLowering.cpp
>+++ b/lib/Target/R600/SIISelLowering.cpp
>@@ -156,8 +156,9 @@ SDValue SITargetLowering::LowerFormalArguments(
> 
>   for (unsigned i = 0, e = Ins.size(), ArgIdx = 0; i != e; ++i) {
> 
>+    const ISD::InputArg &Arg = Ins[i];
>     if (Skipped & (1 << i)) {
>-      InVals.push_back(SDValue());
>+      InVals.push_back(DAG.getUNDEF(Arg.VT));
>       continue;
>     }
> 
>@@ -181,7 +182,6 @@ SDValue SITargetLowering::LowerFormalArguments(
>     Reg = MF.addLiveIn(Reg, RC);
>     SDValue Val = DAG.getCopyFromReg(Chain, DL, Reg, VT);
> 
>-    const ISD::InputArg &Arg = Ins[i];
>     if (Arg.VT.isVector()) {
> 
>       // Build a vector from the registers
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 64694: 79451 | 79457

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.