Bug 64694 - xorg fail to start after llvm upgrade
Summary: xorg fail to start after llvm upgrade
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/radeonsi (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: highest blocker
Assignee: Christian König
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 03:32 UTC by Rafael Castillo
Modified: 2013-05-17 14:15 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
crash image (612.20 KB, image/jpeg)
2013-05-17 03:32 UTC, Rafael Castillo 		Details
Possible fix (1.28 KB, patch)
2013-05-17 09:02 UTC, Christian König 		Details | Splinter Review
View All

Description Rafael Castillo 2013-05-17 03:32:22 UTC 
Created attachment 79451 [details]
crash image

After update llvm to 16/05/2013 svn and mesa git xorg crashes giving a list of symbols of selectiondag and passmanager.

ILl atach image feom the crash(writing from my tablet)
Comment 1 Michel Dänzer 2013-05-17 08:17:38 UTC 
I bisected this to LLVM r182062: 'Generate debug info for by-value struct args even if they are not used.' Enabling the DEBUG code in SelectionDAGISel::LowerArguments(), it complains that "LowerFormalArguments emitted a null value!".

I suspect SITargetLowering::LowerFormalArguments() needs to be adapted for this, but I'm not sure how. Christian, can you take a look?
Comment 2 Christian König 2013-05-17 09:02:49 UTC 
Created attachment 79457 [details] [review]
Possible fix

Does this patch helps?
Comment 3 Michel Dänzer 2013-05-17 09:32:37 UTC 
(In reply to comment #2)
> Does this patch helps?

It does, thanks!

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Tested-by: Michel Dänzer <michel.daenzer@amd.com>
Comment 4 Christian König 2013-05-17 09:48:46 UTC 
Fix pushed upstream.

Thx for the help.
Comment 5 Rafael Castillo 2013-05-17 14:15:30 UTC 
as always many thx for your help, very much appreciated

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.