Attachment 85143 Details for Bug 68905 – 2/2] Add a regression test for a "no SimplePresence" special case

[patch] 2/2] Add a regression test for a "no SimplePresence" special case

0002-Add-a-regression-test-for-a-no-SimplePresence-specia.patch (text/plain), 1.77 KB, created by Simon McVittie on 2013-09-03 19:13:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-09-03 19:13:20 UTC

Size: 1.77 KB

patch

obsolete

>From e24b1dc104589fc3ac6cbb7b557a15ddcedab770 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 28 Aug 2013 15:36:14 +0100
>Subject: [PATCH 2/2] Add a regression test for a "no SimplePresence" special
> case
>
>CurrentPresence should toggle between OFFLINE and UNSET if the account
>has no concept of presence.
>---
> tests/twisted/account-manager/irc.py | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/tests/twisted/account-manager/irc.py b/tests/twisted/account-manager/irc.py
>index 36bd283..6575aed 100644
>--- a/tests/twisted/account-manager/irc.py
>+++ b/tests/twisted/account-manager/irc.py
>@@ -1,7 +1,10 @@
> # encoding: utf-8
> #
>+# Test the odd things about IRC: it has no presence, and nicknames
>+# are the same thing as identifiers.
>+#
> # Copyright Â© 2009 Nokia Corporation
>-# Copyright Â© 2009-2012 Collabora Ltd.
>+# Copyright Â© 2009-2013 Collabora Ltd.
> #
> # This library is free software; you can redistribute it and/or
> # modify it under the terms of the GNU Lesser General Public
>@@ -53,9 +56,14 @@ def test(q, bus, mc):
>             EventPattern('dbus-method-call',
>                 interface=cs.CONN_IFACE_ALIASING, method='SetAliases',
>                 handled=False),
>+            EventPattern('dbus-signal',
>+                interface=cs.ACCOUNT,
>+                predicate=lambda e:
>+                    e.args[0].get('CurrentPresence') ==
>+                        (cs.PRESENCE_TYPE_UNSET, '', '')),
>             ]
> 
>-    conn, get_aliases, set_aliases = enable_fakecm_account(q, bus, mc,
>+    conn, get_aliases, set_aliases, _ = enable_fakecm_account(q, bus, mc,
>             account, params, has_aliasing=True,
>             expect_after_connect=expect_after_connect,
>             self_ident=params['account'])
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 68905: 85142 | 85143

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.