Bug 68905 - Use the self-TpContact to track presence
Summary: Use the self-TpContact to track presence
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-09-03 19:11 UTC by Simon McVittie
Modified: 2013-09-04 12:56 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
1/2] Track presence via TpContact, not McdConnection (9.94 KB, patch)
2013-09-03 19:12 UTC, Simon McVittie
Details | Splinter Review
2/2] Add a regression test for a "no SimplePresence" special case (1.77 KB, patch)
2013-09-03 19:13 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-09-03 19:11:50 UTC
telepathy-glib is a lot more helpful than it was when MC was written.
Comment 1 Simon McVittie 2013-09-03 19:12:25 UTC
Created attachment 85142 [details] [review]
1/2] Track presence via TpContact, not McdConnection

Now that McdAccount has a TpContact for the self-contact, this is
really easy.
---
 src/mcd-account.c    | 68 ++++++++++++++++++++++------------------------------
 src/mcd-connection.c | 67 ---------------------------------------------------
 2 files changed, 29 insertions(+), 106 deletions(-)
Comment 2 Simon McVittie 2013-09-03 19:13:20 UTC
Created attachment 85143 [details] [review]
2/2] Add a regression test for a "no SimplePresence" special case

CurrentPresence should toggle between OFFLINE and UNSET if the account
has no concept of presence.

---

This already worked, but we didn't test it.
Comment 3 Guillaume Desmottes 2013-09-04 07:22:22 UTC
Comment on attachment 85142 [details] [review]
1/2] Track presence via TpContact, not McdConnection

Review of attachment 85142 [details] [review]:
-----------------------------------------------------------------

++
Comment 4 Guillaume Desmottes 2013-09-04 07:22:41 UTC
Comment on attachment 85143 [details] [review]
2/2] Add a regression test for a "no SimplePresence" special case

Review of attachment 85143 [details] [review]:
-----------------------------------------------------------------

++
Comment 5 Simon McVittie 2013-09-04 12:56:44 UTC
Fixed in git master for 5.15.1.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.