Attachment 86664 Details for Bug 69855 – [tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting with underscore

[patch] [tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting with underscore

0004-tp_connection_manager_check_valid_name-allow-startin.patch (text/plain), 1.10 KB, created by Simon McVittie on 2013-09-26 18:32:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-09-26 18:32:52 UTC

Size: 1.10 KB

patch

obsolete

>From c16b1813752b36da09a2d3002807a629657b0d53 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 26 Sep 2013 19:13:28 +0100
>Subject: [PATCH 4/4] tp_connection_manager_check_valid_name: allow starting
> with underscore
>
>telepathy-spec 0.99.1 doesn't allow this, but I think 1.0 should.
>---
> telepathy-glib/connection-manager.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/telepathy-glib/connection-manager.c b/telepathy-glib/connection-manager.c
>index 72296c5..bba3a42 100644
>--- a/telepathy-glib/connection-manager.c
>+++ b/telepathy-glib/connection-manager.c
>@@ -1564,11 +1564,11 @@ tp_connection_manager_check_valid_name (const gchar *name,
>       return FALSE;
>     }
> 
>-  if (!g_ascii_isalpha (name[0]))
>+  if (!g_ascii_isalpha (name[0]) && *name_char != '_')
>     {
>       g_set_error (error, TP_ERROR, TP_ERROR_INVALID_ARGUMENT,
>           "Not a valid connection manager name because first character "
>-          "is not an ASCII letter: %s", name);
>+          "is not an ASCII letter or underscore: %s", name);
>       return FALSE;
>     }
> 
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 69855: 86660 | 86661 | 86662 | 86663 | 86664 | 86665 | 86666

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.