Bug 69855 - get consensus on what protocol names look like
Summary: get consensus on what protocol names look like
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: general (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 69431 69854
  Show dependency treegraph
 
Reported: 2013-09-26 18:27 UTC by Simon McVittie
Modified: 2013-09-27 14:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
[spec/next] allow Connection_Manager_Name to start with an underscore (1.17 KB, patch)
2013-09-26 18:30 UTC, Simon McVittie
Details | Splinter Review
[tp-glib/next 1/4] Allow protocol names to start with "_", because tp-spec 0.99.1 says so (1.36 KB, patch)
2013-09-26 18:31 UTC, Simon McVittie
Details | Splinter Review
[tp-glib/next 2/4] TpAccount: if synthesizing icon name from protocol name, s/_/-/ (1.57 KB, patch)
2013-09-26 18:32 UTC, Simon McVittie
Details | Splinter Review
[tp-glib/next 3/4] TpAccount: use underscores in example service names (1.10 KB, patch)
2013-09-26 18:32 UTC, Simon McVittie
Details | Splinter Review
[tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting with underscore (1.10 KB, patch)
2013-09-26 18:32 UTC, Simon McVittie
Details | Splinter Review
[haze/next] Use underscores, not hyphen/minus, in Protocol names (5.56 KB, patch)
2013-09-26 18:33 UTC, Simon McVittie
Details | Splinter Review
[mc/next] Allow client names to start with an underscore (978 bytes, patch)
2013-09-26 18:34 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-09-26 18:27:18 UTC
Haze 'next' assumes link-local XMPP will be local-xmpp; Salut assumes it will be local_xmpp. That can't work.

My plan is to do a telepathy-glib 0.99.2 snapshot that standardizes on the "underscore" version, but skip telepathy-spec 0.99.2 because we haven't changed anything significant there yet.
Comment 1 Simon McVittie 2013-09-26 18:30:57 UTC
Created attachment 86660 [details] [review]
[spec/next] allow Connection_Manager_Name to start with an underscore

There's no real reason not to allow this.
Comment 2 Simon McVittie 2013-09-26 18:31:47 UTC
Created attachment 86661 [details] [review]
[tp-glib/next 1/4] Allow protocol names to start with "_", because tp-spec  0.99.1 says so
Comment 3 Simon McVittie 2013-09-26 18:32:13 UTC
Created attachment 86662 [details] [review]
[tp-glib/next 2/4] TpAccount: if synthesizing icon name from protocol name,  s/_/-/

Freedesktop icon names conventionally look-like-this, but we've changed
the definition of a protocol name in 1.0 so it looks_like_this.
Comment 4 Simon McVittie 2013-09-26 18:32:32 UTC
Created attachment 86663 [details] [review]
[tp-glib/next 3/4] TpAccount: use underscores in example service names

The convention is that they look like protocol names, and we've
changed the definition of protocol names.
Comment 5 Simon McVittie 2013-09-26 18:32:52 UTC
Created attachment 86664 [details] [review]
[tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting  with underscore

telepathy-spec 0.99.1 doesn't allow this, but I think 1.0 should.
Comment 6 Simon McVittie 2013-09-26 18:33:31 UTC
Created attachment 86665 [details] [review]
[haze/next] Use underscores, not hyphen/minus, in Protocol names

Also make sure there are no odd characters in the Protocol name, and
make sure it doesn't start with a digit.

---

Last patch here.
Comment 7 Simon McVittie 2013-09-26 18:34:45 UTC
Created attachment 86666 [details] [review]
[mc/next] Allow client names to start with an underscore

There's no good reason not to, and telepathy-spec 0.99.1 says they can.

---

Sorry, *this* is the last patch.
Comment 8 Guillaume Desmottes 2013-09-27 07:16:26 UTC
Comment on attachment 86660 [details] [review]
[spec/next] allow Connection_Manager_Name to start with an underscore

Review of attachment 86660 [details] [review]:
-----------------------------------------------------------------

ok.
Comment 9 Guillaume Desmottes 2013-09-27 07:16:45 UTC
Comment on attachment 86661 [details] [review]
[tp-glib/next 1/4] Allow protocol names to start with "_", because tp-spec  0.99.1 says so

Review of attachment 86661 [details] [review]:
-----------------------------------------------------------------

++
Comment 10 Guillaume Desmottes 2013-09-27 07:17:45 UTC
Comment on attachment 86662 [details] [review]
[tp-glib/next 2/4] TpAccount: if synthesizing icon name from protocol name,  s/_/-/

Review of attachment 86662 [details] [review]:
-----------------------------------------------------------------

++
Comment 11 Guillaume Desmottes 2013-09-27 07:18:27 UTC
Comment on attachment 86663 [details] [review]
[tp-glib/next 3/4] TpAccount: use underscores in example service names

Review of attachment 86663 [details] [review]:
-----------------------------------------------------------------

++
Comment 12 Guillaume Desmottes 2013-09-27 07:18:44 UTC
Comment on attachment 86664 [details] [review]
[tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting  with underscore

Review of attachment 86664 [details] [review]:
-----------------------------------------------------------------

++
Comment 13 Guillaume Desmottes 2013-09-27 07:19:38 UTC
Comment on attachment 86665 [details] [review]
[haze/next] Use underscores, not hyphen/minus, in Protocol names

Review of attachment 86665 [details] [review]:
-----------------------------------------------------------------

++
Comment 14 Guillaume Desmottes 2013-09-27 07:19:52 UTC
Comment on attachment 86666 [details] [review]
[mc/next] Allow client names to start with an underscore

Review of attachment 86666 [details] [review]:
-----------------------------------------------------------------

++
Comment 15 Simon McVittie 2013-09-27 14:07:53 UTC
0.99.2, thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.