Attachment 86666 Details for Bug 69855 – [mc/next] Allow client names to start with an underscore

[patch] [mc/next] Allow client names to start with an underscore

0005-Allow-client-names-to-start-with-an-underscore.patch (text/plain), 978 bytes, created by Simon McVittie on 2013-09-26 18:34:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-09-26 18:34:45 UTC

Size: 978 bytes

patch

obsolete

>From 62ae6d87701f34e222168ed4f505f08bc4d00103 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 26 Sep 2013 19:18:25 +0100
>Subject: [PATCH 5/5] Allow client names to start with an underscore
>
>There's no good reason not to, and telepathy-spec 0.99.1 says they can.
>---
> src/mcd-client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/mcd-client.c b/src/mcd-client.c
>index 455cfd7..c2a6427 100644
>--- a/src/mcd-client.c
>+++ b/src/mcd-client.c
>@@ -1162,10 +1162,10 @@ _mcd_client_check_valid_name (const gchar *name_suffix,
> {
>     guint i;
> 
>-    if (!g_ascii_isalpha (*name_suffix))
>+    if (!g_ascii_isalpha (*name_suffix) && *name_suffix != '_')
>     {
>         g_set_error (error, TP_ERROR, TP_ERROR_INVALID_ARGUMENT,
>-                     "Client names must start with a letter");
>+                     "Client names must start with a letter or underscore");
>         return FALSE;
>     }
> 
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 69855: 86660 | 86661 | 86662 | 86663 | 86664 | 86665 | 86666

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.