Attachment 87429 Details for Bug 70367 – Add support for saving/restoring keyboard backlights

[patch] Add support for saving/restoring keyboard backlights

Add-support-for-savingrestoring-keyboard-backlight.patch (text/plain), 2.64 KB, created by Bastien Nocera on 2013-10-11 07:48:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bastien Nocera

Created: 2013-10-11 07:48:17 UTC

Size: 2.64 KB

patch

obsolete

>From 97848d4bdf9ba326bde509b27cbaf538574104a6 Mon Sep 17 00:00:00 2001
>From: Bastien Nocera <hadess@hadess.net>
>Date: Fri, 11 Oct 2013 09:45:32 +0200
>Subject: [PATCH] Add support for saving/restoring keyboard backlights
>
>Piggy-backing on the display backlight code, this saves and restores
>keyboard backlights on supported devices.
>
>The detection code matches that of UPower:
>http://cgit.freedesktop.org/upower/tree/src/up-kbd-backlight.c#n173
>
>NOTE: Untested.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=70367
>---
> rules/99-systemd.rules.in | 4 +++-
> src/backlight/backlight.c | 5 ++++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/rules/99-systemd.rules.in b/rules/99-systemd.rules.in
>index bbb7d0c..b7c9a1d 100644
>--- a/rules/99-systemd.rules.in
>+++ b/rules/99-systemd.rules.in
>@@ -51,9 +51,11 @@ SUBSYSTEM=="usb", ENV{DEVTYPE}=="usb_device", ENV{ID_USB_INTERFACES}=="*:0701??:
> 
> ACTION=="add", SUBSYSTEM=="net", KERNEL!="lo", RUN+="@rootlibexecdir@/systemd-sysctl --prefix=/proc/sys/net/ipv4/conf/$name --prefix=/proc/sys/net/ipv4/neigh/$name --prefix=/proc/sys/net/ipv6/conf/$name --prefix=/proc/sys/net/ipv6/neigh/$name"
> 
>-# Pull in backlight save/restore for all firmware backlight devices
>+# Pull in backlight save/restore for all firmware backlight devices,
>+# and keyboard backlights
> 
> ACTION=="add", SUBSYSTEM=="backlight", ATTR{type}=="firmware", TAG+="systemd", ENV{SYSTEMD_WANTS}+="systemd-backlight@$name.service"
>+ACTION=="add", SUBSYSTEM=="leds", KERNEL=="kbd_backlight", TAG+="systemd", ENV{SYSTEMD_WANTS}+="systemd-backlight@$name.service"
> 
> # Asynchronously mount file systems implemented by these modules as
> # soon as they are loaded.
>diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c
>index 9b2eada..2f67a17 100644
>--- a/src/backlight/backlight.c
>+++ b/src/backlight/backlight.c
>@@ -56,6 +56,8 @@ int main(int argc, char *argv[]) {
> 
>         errno = 0;
>         device = udev_device_new_from_subsystem_sysname(udev, "backlight", argv[2]);
>+        if (!device)
>+                device = udev_device_new_from_subsystem_sysname(udev, "leds", argv[2]);
>         if (!device) {
>                 if (errno != 0) {
>                         log_error("Failed to get backlight device: %m");
>@@ -66,7 +68,8 @@ int main(int argc, char *argv[]) {
>                 goto finish;
>         }
> 
>-        if (!streq_ptr(udev_device_get_subsystem(device), "backlight")) {
>+        if (!streq_ptr(udev_device_get_subsystem(device), "backlight") &&
>+            !streq_ptr(udev_device_get_subsystem(device), "leds")) {
>                 log_error("Not a backlight device: %s", argv[2]);
>                 r = -ENODEV;
>                 goto finish;
>-- 
>1.8.3.1

Actions: View | Splinter Review

Attachments on bug 70367: 87429

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.