Attachment 89315 Details for Bug 71049 – replicate edp bpp hack for hsw

[patch] replicate edp bpp hack for hsw

0001-drm-i915-Replicate-BIOS-eDP-bpp-clamping-hack-for-hs.patch (text/plain), 2.00 KB, created by Daniel Vetter on 2013-11-16 13:13:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2013-11-16 13:13:52 UTC

Size: 2.00 KB

patch

obsolete

>From 577fa79f134de616610524676e3703a5a0ded390 Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Sat, 16 Nov 2013 14:11:45 +0100
>Subject: [PATCH] drm/i915: Replicate BIOS eDP bpp clamping hack for hsw
>
>Haswell's DDI encoders have their own ->get_config callback and in
>
>commit c6cd2ee2d59111a07cd9199564c9bdcb2d11e5cf
>Author: Jani Nikula <jani.nikula@intel.com>
>Date:   Mon Oct 21 10:52:07 2013 +0300
>
>    drm/i915/dp: workaround BIOS eDP bpp clamping issue
>
>we've forgotten to replicate this hack. So let's do it that.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71049
>Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/intel_ddi.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
>index 1591576a6101..04406029bf12 100644
>--- a/drivers/gpu/drm/i915/intel_ddi.c
>+++ b/drivers/gpu/drm/i915/intel_ddi.c
>@@ -1406,6 +1406,28 @@ void intel_ddi_get_config(struct intel_encoder *encoder,
> 	default:
> 		break;
> 	}
>+
>+	if (encoder->type == INTEL_OUTPUT_EDP && dev_priv->vbt.edp_bpp &&
>+	    pipe_config->pipe_bpp > dev_priv->vbt.edp_bpp) {
>+		struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
>+
>+		/*
>+		 * This is a big fat ugly hack.
>+		 *
>+		 * Some machines in UEFI boot mode provide us a VBT that has 18
>+		 * bpp and 1.62 GHz link bandwidth for eDP, which for reasons
>+		 * unknown we fail to light up. Yet the same BIOS boots up with
>+		 * 24 bpp and 2.7 GHz link. Use the same bpp as the BIOS uses as
>+		 * max, not what it tells us to use.
>+		 *
>+		 * Note: This will still be broken if the eDP panel is not lit
>+		 * up by the BIOS, and thus we can't get the mode at module
>+		 * load.
>+		 */
>+		DRM_DEBUG_KMS("pipe has %d bpp for eDP panel, overriding BIOS-provided max %d bpp\n",
>+			      pipe_config->pipe_bpp, dev_priv->vbt.edp_bpp);
>+		dev_priv->vbt.edp_bpp = pipe_config->pipe_bpp;
>+	}
> }
> 
> static void intel_ddi_destroy(struct drm_encoder *encoder)
>-- 
>1.8.4.3
>

Actions: View | Splinter Review

Attachments on bug 71049: 88363 | 88364 | 88365 | 88366 | 88367 | 88368 | 88369 | 88419 | 88803 | 88804 | 89161 | 89162 | 89175 | 89176 | 89315

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.