Attachment 89696 Details for Bug 69765 – patch

[patch] patch

0001-icc-store-Don-t-create-legacy-locations.patch (text/plain), 1.12 KB, created by Matthias Clasen on 2013-11-23 22:50:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Clasen

Created: 2013-11-23 22:50:27 UTC

Size: 1.12 KB

patch

obsolete

>From aaac7827597ad1b806f7cb40ae97eeab9cfce623 Mon Sep 17 00:00:00 2001
>From: Matthias Clasen <mclasen@redhat.com>
>Date: Sat, 23 Nov 2013 17:47:37 -0500
>Subject: [PATCH] icc store: Don't create legacy locations
>
>When cd_icc_store_search_kind is called with the
>CD_ICC_STORE_SEARCH_FLAGS_CREATE_LOCATION flag, it creates
>all the locations for the given kind. That is not really
>ideal, since all but the first one are basically legacy,
>and should not be forced into existence. The patch changes
>things so that the create-location flag only affects the
>first location.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=69765
>---
> lib/colord/cd-icc-store.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/lib/colord/cd-icc-store.c b/lib/colord/cd-icc-store.c
>index 10af71b..8973130 100644
>--- a/lib/colord/cd-icc-store.c
>+++ b/lib/colord/cd-icc-store.c
>@@ -663,6 +663,9 @@ cd_icc_store_search_kind (CdIccStore *store,
> 						    search_flags,
> 						    cancellable,
> 						    error);
>+                /* only create the first location */
>+		search_flags &= ~CD_ICC_STORE_SEARCH_FLAGS_CREATE_LOCATION;
>+
> 		if (!ret)
> 			goto out;
> 	}
>-- 
>1.8.4.2
>

Actions: View | Splinter Review

Attachments on bug 69765: 89696

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.