Bug 69765 - How about get rid of ~/.colord and use XDG standard dirs instead?
Summary: How about get rid of ~/.colord and use XDG standard dirs instead?
Status: RESOLVED FIXED
Alias: None
Product: colord
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 18:08 UTC by lh
Modified: 2013-11-25 08:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
patch (1.12 KB, patch)
2013-11-23 22:50 UTC, Matthias Clasen
Details | Splinter Review

Description lh 2013-09-24 18:08:55 UTC
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

How about move the configure files to XDG dirs(~/.config/color, etc).

PS: Colord seems always trying to create ~/.color/icc even if users didn't change anything.
Comment 1 Richard Hughes 2013-09-25 09:27:43 UTC
$ cat ~/.config/color
cat: /home/hughsie/.config/color: No such file or directory

~/.color/icc is the deprecated location for icc profiles. It's been replaced by ~/.local/share/icc/ -- both are monitored by the session component. Are you using gnome-settings-daemon, colord-kde or xiccd?
Comment 2 lh 2013-09-26 12:42:35 UTC
(In reply to comment #1)
> $ cat ~/.config/color
> cat: /home/hughsie/.config/color: No such file or directory
> 
> ~/.color/icc is the deprecated location for icc profiles. It's been replaced
> by ~/.local/share/icc/ -- both are monitored by the session component. Are
> you using gnome-settings-daemon, colord-kde or xiccd?

Hi, I am using Archlinux, gnome 3.10, colord1.02. I tried to find ".color" in colord-gtk, gnome-settings-daemon, gnome-color-manager, seems all irrelevant.

I tried many applications, "~/.color/icc" appears after I open "gnome-settings-daemon".

I modified the code of colord, removed two lines in cd-icc-store.c, and "~/.color/icc" didn't showed up again.

Overall, I don't really know where is the problem.
Comment 3 Matthias Clasen 2013-11-23 22:49:31 UTC
The gsd color plugin calls:

        ret = cd_icc_store_search_kind (priv->icc_store,
                                        CD_ICC_STORE_SEARCH_KIND_USER,
                                        CD_ICC_STORE_SEARCH_FLAGS_CREATE_LOCATION,
                                        NULL,
                                        &error);


it explicitly asks to create the location, and from a quick look at the libcolord code, there is no notion of 'create the preferred location, but not the legacy one'.
Comment 4 Matthias Clasen 2013-11-23 22:50:27 UTC
Created attachment 89696 [details] [review]
patch
Comment 5 Richard Hughes 2013-11-25 08:58:03 UTC
Patch applied, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.