Attachment 93050 Details for Bug 33485 – remove CM side password storage API

[patch] remove CM side password storage API

0001-remove-CM-side-password-storage-API.patch (text/plain), 13.47 KB, created by Guillaume Desmottes on 2014-01-30 10:53:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2014-01-30 10:53:42 UTC

Size: 13.47 KB

patch

obsolete

>From 08d793d341e426b2466cf3e57b9846a45b281ef9 Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Thu, 30 Jan 2014 11:52:20 +0100
>Subject: [PATCH] remove CM side password storage API
>
>They have been DRAFT for years and doesn't really make sense.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=33485
>---
> ...ccount_Interface_External_Password_Storage1.xml | 59 ----------
> spec/Channel_Interface_Credentials_Storage1.xml | 60 ----------
> ...nnection_Manager_Interface_Account_Storage1.xml | 121 ---------------------
> spec/all.xml | 3 -
> 4 files changed, 243 deletions(-)
> delete mode 100644 spec/Account_Interface_External_Password_Storage1.xml
> delete mode 100644 spec/Channel_Interface_Credentials_Storage1.xml
> delete mode 100644 spec/Connection_Manager_Interface_Account_Storage1.xml
>
>diff --git a/spec/Account_Interface_External_Password_Storage1.xml b/spec/Account_Interface_External_Password_Storage1.xml
>deleted file mode 100644
>index bfc7fd9..0000000
>--- a/spec/Account_Interface_External_Password_Storage1.xml
>+++ /dev/null
>@@ -1,59 +0,0 @@
>-<?xml version="1.0" ?>
>-<node name="/Account_Interface_External_Password_Storage1"
>- xmlns:tp="http://telepathy.freedesktop.org/wiki/DbusSpec#extensions-v0">
>-
>- <tp:copyright>Copyright Â© 2011 Collabora Ltd.</tp:copyright>
>- <tp:license xmlns="http://www.w3.org/1999/xhtml">
>- This library is free software; you can redistribute it and/or
>- modify it under the terms of the GNU Lesser General Public
>- License as published by the Free Software Foundation; either
>- version 2.1 of the License, or (at your option) any later version.
>-
>- This library is distributed in the hope that it will be useful,
>- but WITHOUT ANY WARRANTY; without even the implied warranty of
>- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>- Lesser General Public License for more details.
>-
>- You should have received a copy of the GNU Lesser General Public
>- License along with this library; if not, write to the Free Software
>- Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
>- 02110-1301, USA.
>- </tp:license>
>-
>- <interface name="im.telepathy.v1.Account.Interface.ExternalPasswordStorage1"
>- tp:causes-havoc="experimental">
>- 
>- <tp:added version="0.21.10">(draft 1)</tp:added>
>- <tp:requires interface="im.telepathy.v1.Account"/>
>-
>- <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>- An interface for Accounts whose passwords are stored externally and
>- SHOULD NOT be stored by either the
>- <tp:dbus-ref namespace="imt1">AccountManager</tp:dbus-ref> nor any
>- <tp:dbus-ref namespace="imt1.Channel.Type">ServerAuthentication1</tp:dbus-ref>
>- handler.
>-
>- This interface SHOULD only appear on accounts for which the
>- related Connection Manager implements
>- <tp:dbus-ref namespace="imt1">ConnectionManager.Interface.AccountStorage1</tp:dbus-ref>.
>- </tp:docstring>
>-
>- <method name="ForgetPassword" tp:name-for-bindings="Forget_Password">
>- <tp:docstring>
>- Clears any saved password associated with this account.
>- </tp:docstring>
>- </method>
>-
>- <property name="PasswordSaved"
>- tp:name-for-bindings="Password_Saved"
>- type="b" access="read">
>- <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>- Indicates whether the account has a saved password or not.
>-
>- Change notification for this property is provided by the
>- standard D-Bus <code>PropertiesChanged</code> signal.
>- </tp:docstring>
>- </property>
>-
>- </interface>
>-</node>
>diff --git a/spec/Channel_Interface_Credentials_Storage1.xml b/spec/Channel_Interface_Credentials_Storage1.xml
>deleted file mode 100644
>index 00ecd5b..0000000
>--- a/spec/Channel_Interface_Credentials_Storage1.xml
>+++ /dev/null
>@@ -1,60 +0,0 @@
>-<?xml version="1.0" ?>
>-<node name="/Channel_Interface_Credentials_Storage1"
>- xmlns:tp="http://telepathy.freedesktop.org/wiki/DbusSpec#extensions-v0">
>- <tp:copyright> Copyright Â© 2011 Collabora Limited </tp:copyright>
>- <tp:license xmlns="http://www.w3.org/1999/xhtml">
>- This library is free software; you can redistribute it and/or
>-modify it under the terms of the GNU Lesser General Public
>-License as published by the Free Software Foundation; either
>-version 2.1 of the License, or (at your option) any later version.
>-
>-This library is distributed in the hope that it will be useful,
>-but WITHOUT ANY WARRANTY; without even the implied warranty of
>-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>-Lesser General Public License for more details.
>-
>-You should have received a copy of the GNU Lesser General Public
>-License along with this library; if not, write to the Free Software
>-Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
>- </tp:license>
>- <interface name="im.telepathy.v1.Channel.Interface.CredentialsStorage1"
>- tp:causes-havoc="experimental">
>- 
>- <tp:added version="0.21.10">(draft 1)</tp:added>
>- <tp:requires interface="im.telepathy.v1.Channel.Interface.SASLAuthentication1"/>
>- <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>- A channel interface for SASL authentication channels that can save the
>- credentials in the connection manager.
>-
>- This interface is unlikely to be present for any SASL channels that are
>- more complex than a simple password prompt (e.g.
>- <code>X-TELEPATHY-PASSWORD</code> or <code>PLAIN</code>).
>-
>- In practice, this interface should only be implemented by connection
>- managers that implement the <tp:dbus-ref
>- namespace="imt1">ConnectionManager.Interface.AccountStorage1</tp:dbus-ref>
>- interface. To clear a password that has been saved in this manner, a
>- client should call <tp:dbus-ref
>- namespace="imt1.ConnectionManager.Interface">AccountStorage1.ForgetCredentials</tp:dbus-ref>
>- on the Account.
>- </tp:docstring>
>-
>- <method name="StoreCredentials" tp:name-for-bindings="Store_Credentials">
>- <arg direction="in" name="Store" type="b">
>- <tp:docstring>
>- Whether to store the authentication credentials.
>- </tp:docstring>
>- </arg>
>- <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>- This method tells the connection manager whether to store the
>- authentication response in order to allow the connection manager to
>- sign-on automatically in the future.
>- If credentials have been stored in this way, the client SHOULD NOT
>- attempt to store the credentials locally in a keyring.
>- This method MUST be called before <tp:dbus-ref
>- namespace="im.telepathy.v1.Channel.Interface.SASLAuthentication1">AcceptSASL</tp:dbus-ref>
>- is called or it will have no effect.
>- </tp:docstring>
>- </method>
>- </interface>
>-</node>
>diff --git a/spec/Connection_Manager_Interface_Account_Storage1.xml b/spec/Connection_Manager_Interface_Account_Storage1.xml
>deleted file mode 100644
>index c50a255..0000000
>--- a/spec/Connection_Manager_Interface_Account_Storage1.xml
>+++ /dev/null
>@@ -1,121 +0,0 @@
>-<?xml version="1.0" ?>
>-<node name="/Connection_Manager_Interface_Account_Storage1"
>- xmlns:tp="http://telepathy.freedesktop.org/wiki/DbusSpec#extensions-v0">
>-
>- <tp:copyright>Copyright Â© 2011 Collabora Ltd.</tp:copyright>
>- <tp:license xmlns="http://www.w3.org/1999/xhtml">
>- This library is free software; you can redistribute it and/or
>- modify it under the terms of the GNU Lesser General Public
>- License as published by the Free Software Foundation; either
>- version 2.1 of the License, or (at your option) any later version.
>-
>- This library is distributed in the hope that it will be useful,
>- but WITHOUT ANY WARRANTY; without even the implied warranty of
>- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>- Lesser General Public License for more details.
>-
>- You should have received a copy of the GNU Lesser General Public
>- License along with this library; if not, write to the Free Software
>- Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
>- 02110-1301, USA.
>- </tp:license>
>-
>- <interface name="im.telepathy.v1.ConnectionManager.Interface.AccountStorage1"
>- tp:causes-havoc="experimental">
>- 
>- <tp:added version="0.21.10">(draft 1)</tp:added>
>- <tp:requires interface="im.telepathy.v1.ConnectionManager"/>
>-
>- <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>- An interface for connection managers that store account details
>- internally. At the moment this consists only of storing an account's
>- credentials, but other functionality may be added in the future.
>-
>- <tp:dbus-ref namespace="imt1">Account</tp:dbus-ref> objects
>- representing accounts on a connection manager that implements this
>- interface should implement the
>-	<tp:dbus-ref namespace="imt1.Account.Interface">ExternalPasswordStorage1</tp:dbus-ref>
>- interface.
>- </tp:docstring>
>-
>- <tp:flags name="Account_Flags" value-prefix="Account_Flag" type="u">
>- <tp:docstring>
>- A set of flags representing the status of the Account stored in the
>- Connection Manager.
>- </tp:docstring>
>-
>- <tp:flag suffix="Credentials_Stored" value="1">
>- <tp:docstring>
>- The associated account has its authentication credentials (password)
>- stored in the connection manager
>- </tp:docstring>
>- </tp:flag>
>- </tp:flags>
>-
>- <tp:mapping name="Account_Flags_Map" array-name="Account_Flags_Map_List">
>- <tp:docstring>A mapping from Account_Ids to account flags.
>- </tp:docstring>
>- <tp:member type="s" name="Account_Id"/>
>- <tp:member type="u" tp:type="Account_Flags" name="Flags"/>
>- </tp:mapping>
>-
>- <property name="Accounts"
>- tp:name-for-bindings="Accounts"
>- type="a{su}" tp:type="Account_Flags_Map" access="read">
>- <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>- The set of Accounts stored in this Connection Manager, and flags
>- indicating their status.
>-
>- Change notification for this property is provided by the standard
>- D-Bus <code>PropertiesChanged</code> signal.
>- </tp:docstring>
>- </property>
>-
>- <method name="ForgetCredentials" tp:name-for-bindings="Forget_Credentials">
>- <tp:docstring>
>- Clears any saved credentials associated with the specified Account_Id.
>- Any other saved data related to the account will be unaffected.
>- </tp:docstring>
>-
>- <arg direction="in" name="Account_Id"
>- type="s">
>- <tp:docstring>
>- An account id as returned from
>-	 <tp:dbus-ref namespace="imt1">Protocol.IdentifyAccount</tp:dbus-ref>.
>- </tp:docstring>
>- </arg>
>-
>- <tp:possible-errors>
>- <tp:error name="im.telepathy.v1.Error.InvalidArgument">
>- <tp:docstring>
>- The account id is invalid.
>- </tp:docstring>
>- </tp:error>
>- </tp:possible-errors>
>- </method>
>-
>- <method name="RemoveAccount" tp:name-for-bindings="Remove_Account">
>- <tp:docstring>
>- Completely removes all data associated with an account from the
>- connection manager's internal storage.
>- </tp:docstring>
>-
>- <arg direction="in" name="Account_Id"
>- type="s">
>- <tp:docstring>
>- An account id as returned from
>-	 <tp:dbus-ref namespace="imt1">Protocol.IdentifyAccount</tp:dbus-ref>.
>- </tp:docstring>
>- </arg>
>-
>- <tp:possible-errors>
>- <tp:error name="im.telepathy.v1.Error.InvalidArgument">
>- <tp:docstring>
>- The account id is invalid.
>- </tp:docstring>
>- </tp:error>
>- </tp:possible-errors>
>- </method>
>-
>- </interface>
>-</node>
>diff --git a/spec/all.xml b/spec/all.xml
>index 26fd31d..d9257b8 100644
>--- a/spec/all.xml
>+++ b/spec/all.xml
>@@ -32,7 +32,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
> 
> </tp:docstring>
> <xi:include href="Connection_Manager.xml"/>
>- <xi:include href="Connection_Manager_Interface_Account_Storage1.xml"/>
> <xi:include href="Protocol.xml"/>
> <xi:include href="Protocol_Interface_Addressing1.xml"/>
> <xi:include href="Protocol_Interface_Avatars1.xml"/>
>@@ -161,7 +160,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
> <xi:include href="Channel_Interface_Room1.xml"/>
> <xi:include href="Channel_Interface_Room_Config1.xml"/>
> <xi:include href="Channel_Interface_SASL_Authentication1.xml"/>
>- <xi:include href="Channel_Interface_Credentials_Storage1.xml"/>
> <xi:include href="Channel_Interface_Securable1.xml"/>
> <xi:include href="Channel_Interface_Service_Point1.xml"/>
> <xi:include href="Channel_Interface_Subject1.xml"/>
>@@ -263,7 +261,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
> <xi:include href="Account_Interface_Addressing1.xml"/>
> <xi:include href="Account_Interface_Avatar1.xml"/>
> <xi:include href="Account_Interface_Storage1.xml"/>
>- <xi:include href="Account_Interface_External_Password_Storage1.xml"/>
> </tp:section>
> 
> <tp:section name="The Channel Dispatcher">
>-- 
>1.8.5.3
>

Actions: View | Splinter Review

Attachments on bug 33485: 93050

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.