Attachment 108894 Details for Bug 79996 – drm/i915: WaSetupGtModeTdRowDispatch:snb considered harmful

[patch] drm/i915: WaSetupGtModeTdRowDispatch:snb considered harmful

0001-drm-i915-WaSetupGtModeTdRowDispatch-snb-considered-h.patch (text/plain), 1.62 KB, created by Mika Kuoppala on 2014-11-04 14:36:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kuoppala

Created: 2014-11-04 14:36:27 UTC

Size: 1.62 KB

patch

obsolete

>From d3923733daaee5a0a56e4ca472b14da066ad355f Mon Sep 17 00:00:00 2001
>From: Mika Kuoppala <mika.kuoppala@intel.com>
>Date: Tue, 4 Nov 2014 16:32:48 +0200
>Subject: [PATCH] drm/i915: WaSetupGtModeTdRowDispatch:snb considered harmful
>
>Apparently setting this bit to limit TD dispatch is causing
>problems. The documentation is as thin as always so give up
>and just leave it to default. Clear all bits to default
>values in case bios decided intervene.
>
>References: https://bugs.freedesktop.org/show_bug.cgi?id=79996
>
>Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>---
> drivers/gpu/drm/i915/intel_pm.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>index 7a69eba..953cdbb 100644
>--- a/drivers/gpu/drm/i915/intel_pm.c
>+++ b/drivers/gpu/drm/i915/intel_pm.c
>@@ -5519,11 +5519,6 @@ static void gen6_init_clock_gating(struct drm_device *dev)
> 	I915_WRITE(_3D_CHICKEN,
> 		   _MASKED_BIT_ENABLE(_3D_CHICKEN_HIZ_PLANE_DISABLE_MSAA_4X_SNB));
> 
>-	/* WaSetupGtModeTdRowDispatch:snb */
>-	if (IS_SNB_GT1(dev))
>-		I915_WRITE(GEN6_GT_MODE,
>-			   _MASKED_BIT_ENABLE(GEN6_TD_FOUR_ROW_DISPATCH_DISABLE));
>-
> 	/* WaDisable_RenderCache_OperationalFlush:snb */
> 	I915_WRITE(CACHE_MODE_0, _MASKED_BIT_DISABLE(RC_OP_FLUSH_ENABLE));
> 
>@@ -5535,6 +5530,7 @@ static void gen6_init_clock_gating(struct drm_device *dev)
> 	 * disable bit, which we don't touch here, but it's good
> 	 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
> 	 */
>+	I915_WRITE(GEN6_GT_MODE, _MASKED_BIT_DISABLE(0xffff));
> 	I915_WRITE(GEN6_GT_MODE,
> 		   GEN6_WIZ_HASHING_MASK | GEN6_WIZ_HASHING_16x4);
> 
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 79996: 100999 | 101181 | 106591 | 108894

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.