Attachment 133937 Details for Bug 102515 – fix cygwin warning v2

[patch] fix cygwin warning v2

0002-Fix-warning-when-compiling-with-cygwin.patch (text/plain), 1.07 KB, created by Adrian Johnson on 2017-09-02 09:30:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Johnson

Created: 2017-09-02 09:30:47 UTC

Size: 1.07 KB

patch

obsolete

>From f2d97ce4e00145ed5c897e1f1f09371043cd0b1a Mon Sep 17 00:00:00 2001
>From: Adrian Johnson <ajohnson@redneon.com>
>Date: Sat, 2 Sep 2017 17:50:58 +0930
>Subject: [PATCH 2/2] Fix warning when compiling with cygwin
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>ImageOutputDev.cc:532:14: warning: âfâ may be used uninitialized in this function [-Wmaybe-uninitialized]
>---
> utils/ImageOutputDev.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/utils/ImageOutputDev.cc b/utils/ImageOutputDev.cc
>index 33cbb714..a7c2faea 100644
>--- a/utils/ImageOutputDev.cc
>+++ b/utils/ImageOutputDev.cc
>@@ -376,7 +376,7 @@ void ImageOutputDev::writeRawImage(Stream *str, const char *ext) {
> 
> void ImageOutputDev::writeImageFile(ImgWriter *writer, ImageFormat format, const char *ext,
>                                     Stream *str, int width, int height, GfxImageColorMap *colorMap) {
>-  FILE *f;
>+  FILE *f = nullptr; /* squelch bogus compiler warning */
>   ImageStream *imgStr = NULL;
>   unsigned char *row;
>   unsigned char *rowp;
>-- 
>2.11.0
>

Actions: View | Splinter Review

Attachments on bug 102515: 133935 | 133936 | 133937 | 133938

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.