Bug 102515 - cygwin build fix
Summary: cygwin build fix
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Cygwin
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-02 08:36 UTC by Adrian Johnson
Modified: 2017-09-02 22:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Fix cygwin build (1.94 KB, patch)
2017-09-02 08:36 UTC, Adrian Johnson 		Details | Splinter Review
fix cygwin warning (1.07 KB, patch)
2017-09-02 08:37 UTC, Adrian Johnson 		Details | Splinter Review
fix cygwin warning v2 (1.07 KB, patch)
2017-09-02 09:30 UTC, Adrian Johnson 		Details | Splinter Review
Fix cygwin build v2 (2.55 KB, patch)
2017-09-02 09:34 UTC, Adrian Johnson 		Details | Splinter Review
Show Obsolete (2) View All

Description Adrian Johnson 2017-09-02 08:36:55 UTC 
Created attachment 133935 [details] [review]
Fix cygwin build

The attached patch fixes a build failure using cygwin 32-bit.
Comment 1 Adrian Johnson 2017-09-02 08:37:47 UTC 
Created attachment 133936 [details] [review]
fix cygwin warning

Also fix a warning that I've only seen on cygwin.
Comment 2 Albert Astals Cid 2017-09-02 09:11:12 UTC 
For cmake we set all the cxx_flags in modules/PopplerMacros.cmake, move it there?
Comment 3 Albert Astals Cid 2017-09-02 09:11:31 UTC 
and also nullptr instead of NULL?
Comment 4 Adrian Johnson 2017-09-02 09:30:47 UTC 
Created attachment 133937 [details] [review]
fix cygwin warning v2

replace NULL with nullptr
Comment 5 Adrian Johnson 2017-09-02 09:34:38 UTC 
Created attachment 133938 [details] [review]
Fix cygwin build v2

moved -D_DEFAULT_SOURCE to PopplerMacros.cmake

I'm not sure what the DEFAULT_COMPILE_WARNINGS_KDE is for but I suspect the "-D_XOPEN_SOURCE=600 -D_BSD_SOURCE" can be removed as they are deprecated by _DEFAULT_SOURCE. See https://lwn.net/Articles/590381/
Comment 6 Albert Astals Cid 2017-09-02 10:58:31 UTC 
Looks good to me, please push.

Yes DEFAULT_COMPILE_WARNINGS_KDE needs removing, useful stuff needs to be moved up to DEFAULT_COMPILE_WARNINGS_YES and the rest just removed. But let's discuss that in the mailing list or in a different bug?
Comment 7 Adrian Johnson 2017-09-02 22:53:45 UTC 
pushed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.