Attachment 36236 Details for Bug 27529 – possible fix

[patch] possible fix

0001-drm-radeon-kms-fix-bandwidth-calculation-when-sidepo.patch (text/plain), 1.60 KB, created by Alex Deucher on 2010-06-12 08:49:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2010-06-12 08:49:12 UTC

Size: 1.60 KB

patch

obsolete

>From 0031f56811335be121cb32fdca3e474788196ccc Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Sat, 12 Jun 2010 11:44:40 -0400
>Subject: [PATCH] drm/radeon/kms: fix bandwidth calculation when sideport is present
>
>Fixes fdo bug 27529:
>https://bugs.freedesktop.org/show_bug.cgi?id=27529
>
>Reported-by: steckdenis@yahoo.fr
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>Cc: stable <stable@kernel.org>
>---
> drivers/gpu/drm/radeon/rs690.c |    6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
>index bcc3319..64b94a8 100644
>--- a/drivers/gpu/drm/radeon/rs690.c
>+++ b/drivers/gpu/drm/radeon/rs690.c
>@@ -228,10 +228,6 @@ void rs690_crtc_bandwidth_compute(struct radeon_device *rdev,
> 	fixed20_12 a, b, c;
> 	fixed20_12 pclk, request_fifo_depth, tolerable_latency, estimated_width;
> 	fixed20_12 consumption_time, line_time, chunk_time, read_delay_latency;
>-	/* FIXME: detect IGP with sideport memory, i don't think there is any
>-	 * such product available
>-	 */
>-	bool sideport = false;
> 
> 	if (!crtc->base.enabled) {
> 		/* FIXME: wouldn't it better to set priority mark to maximum */
>@@ -300,7 +296,7 @@ void rs690_crtc_bandwidth_compute(struct radeon_device *rdev,
> 
> 	/* Maximun bandwidth is the minimun bandwidth of all component */
> 	rdev->pm.max_bandwidth = rdev->pm.core_bandwidth;
>-	if (sideport) {
>+	if (rdev->mc.igp_sideport_enabled) {
> 		if (rdev->pm.max_bandwidth.full > rdev->pm.sideport_bandwidth.full &&
> 			rdev->pm.sideport_bandwidth.full)
> 			rdev->pm.max_bandwidth = rdev->pm.sideport_bandwidth;
>-- 
>1.7.0.1
>

Actions: View | Splinter Review

Attachments on bug 27529: 34782 | 34783 | 34784 | 34785 | 34786 | 34787 | 34788 | 35099 | 36236 | 37917 | 37918 | 38385 | 38645

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.