Attachment 51413 Details for Bug 41023 – Fix error caused by uninitialized union

[patch] Fix error caused by uninitialized union

0001-tag-fix-uninitialized-union-in-d3d1x.patch (text/plain), 1.20 KB, created by Alexandre Demers on 2011-09-20 10:06:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alexandre Demers

Created: 2011-09-20 10:06:24 UTC

Size: 1.20 KB

patch

obsolete

>From e167babfacf0c783cdd66d3ea681a063ad7ff42d Mon Sep 17 00:00:00 2001
>From: Alexandre Demers <alexandre.f.demers@gmail.com>
>Date: Tue, 20 Sep 2011 12:58:18 -0400
>Subject: [PATCH] tag: fix uninitialized union in d3d1x
>
>Fix error introduced previously when moving from an initialized array of
>floats to an uninitialized union. It fixes the compilation error and
>it should initialize the union to blank/black values.
>---
> .../state_trackers/d3d1x/dxgi/src/dxgi_native.cpp  |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/src/gallium/state_trackers/d3d1x/dxgi/src/dxgi_native.cpp b/src/gallium/state_trackers/d3d1x/dxgi/src/dxgi_native.cpp
>index e3329e4..60c1dfd 100644
>--- a/src/gallium/state_trackers/d3d1x/dxgi/src/dxgi_native.cpp
>+++ b/src/gallium/state_trackers/d3d1x/dxgi/src/dxgi_native.cpp
>@@ -1162,7 +1162,7 @@ struct GalliumDXGISwapChain : public GalliumDXGIObject<IDXGISwapChain, GalliumDX
> 		if(1)
> 		{
> 			unsigned blit_x, blit_y, blit_w, blit_h;
>-			static const union pipe_color_union black;
>+			static const union pipe_color_union black = { {0, 0, 0, 0} };
> 
> 			if(!formats_compatible || src->width0 != dst_w || src->height0 != dst_h) {
> 				struct pipe_surface templat;
>-- 
>1.7.4.3
>

Actions: View | Splinter Review

Attachments on bug 41023: 51410 | 51413

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.