When enabling d3d1x state tracker, I receive the following error:
src/dxgi_native.cpp:1165:40: error: uninitialized const ‘black’
So either black shouldn't be a "const" or it should be initialized, which seems to be the problem.
Error introduced by:
gallium: move clear paths from rgba to a pointer to a color union (v2)
11-09-16 4:39 AM
It seems moving from an initialized array of floats to an uninitialized union broke the compilation.
Created attachment 51410 [details] [review]
Initializing "black" union
If I understood correctly unions and how to initialize them, it should fix the compilation error and initialize values to 0 for any of the types. Correct me if I'm wrong.
Created attachment 51413 [details] [review]
Fix error caused by uninitialized union
V2 of the previous patch. Correctly formatted the patch.
How and who should I ask review to? Is there a way to identify the person best placed to review my patch? Thansk.
Calim is probably the only person currently interested in this statetracker. Adding him to CC.
closing the bug. The fix was included in commit 5def3b7be142cfc6bbb1534bd0557c5f324de8c0 by Christoph Bumiller<firstname.lastname@example.org>.
Tested by Alexandre Demers on October 7th, 2011