Attachment 51957 Details for Bug 40103 – channel remap fix

[patch] channel remap fix

0001-drm-radeon-kms-fix-channel_remap-setup.patch (text/plain), 2.66 KB, created by Alex Deucher on 2011-10-04 06:57:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2011-10-04 06:57:20 UTC

Size: 2.66 KB

patch

obsolete

>From f54f8b52c0bf4f556a199fb7a1c1d9b7027ab2f2 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Mon, 3 Oct 2011 20:37:52 -0400
>Subject: [PATCH] drm/radeon/kms: fix channel_remap setup
>
>Most asics just use the hw default value which requires
>no explicit programming.  For those that need a different
>value, the vbios will program it properly.  As such,
>there's no need to program these registers explicitly
>in the driver.  Changing these registers requires a reload
>of all data in vram otherwise its contents will be scambled.
>
>Fixes:
>https://bugs.freedesktop.org/show_bug.cgi?id=40103
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@kernel.org
>---
> drivers/gpu/drm/radeon/evergreen.c |    3 ++-
> drivers/gpu/drm/radeon/ni.c        |    3 ++-
> drivers/gpu/drm/radeon/rv770.c     |    3 ++-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c
>index e8a7467..276509d 100644
>--- a/drivers/gpu/drm/radeon/evergreen.c
>+++ b/drivers/gpu/drm/radeon/evergreen.c
>@@ -2078,7 +2078,8 @@ static void evergreen_gpu_init(struct radeon_device *rdev)
> 	WREG32(DMIF_ADDR_CONFIG, gb_addr_config);
> 	WREG32(HDP_ADDR_CONFIG, gb_addr_config);
> 
>-	evergreen_program_channel_remap(rdev);
>+	/* Use the hw default or as set up by the vbios */
>+	/* evergreen_program_channel_remap(rdev);*/
> 
> 	num_shader_engines = ((RREG32(GB_ADDR_CONFIG) & NUM_SHADER_ENGINES(3)) >> 12) + 1;
> 	grbm_gfx_index = INSTANCE_BROADCAST_WRITES;
>diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c
>index 99fbd79..f15bf6b 100644
>--- a/drivers/gpu/drm/radeon/ni.c
>+++ b/drivers/gpu/drm/radeon/ni.c
>@@ -842,7 +842,8 @@ static void cayman_gpu_init(struct radeon_device *rdev)
> 	WREG32(DMIF_ADDR_CONFIG, gb_addr_config);
> 	WREG32(HDP_ADDR_CONFIG, gb_addr_config);
> 
>-	cayman_program_channel_remap(rdev);
>+	/* Use the hw default or as set up by the vbios */
>+	/* cayman_program_channel_remap(rdev); */
> 
> 	/* primary versions */
> 	WREG32(CC_RB_BACKEND_DISABLE, cc_rb_backend_disable);
>diff --git a/drivers/gpu/drm/radeon/rv770.c b/drivers/gpu/drm/radeon/rv770.c
>index 4720d00..98e3b7e 100644
>--- a/drivers/gpu/drm/radeon/rv770.c
>+++ b/drivers/gpu/drm/radeon/rv770.c
>@@ -785,7 +785,8 @@ static void rv770_gpu_init(struct radeon_device *rdev)
> 	WREG32(DCP_TILING_CONFIG, (gb_tiling_config & 0xffff));
> 	WREG32(HDP_TILING_CONFIG, (gb_tiling_config & 0xffff));
> 
>-	rv770_program_channel_remap(rdev);
>+	/* Use the hw default or as set up by the vbios */
>+	/* rv770_program_channel_remap(rdev); */
> 
> 	WREG32(CC_RB_BACKEND_DISABLE,      cc_rb_backend_disable);
> 	WREG32(CC_GC_SHADER_PIPE_CONFIG,   cc_gc_shader_pipe_config);
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 40103: 50234 | 50236 | 50237 | 50935 | 50959 | 50969 | 50974 | 51806 | 51957

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.