Attachment 52865 Details for Bug 41569 – possible fix

[patch] possible fix

0001-drm-radeon-kms-properly-set-panel-mode-for-eDP.patch (text/plain), 2.47 KB, created by Alex Deucher on 2011-10-28 13:16:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2011-10-28 13:16:46 UTC

Size: 2.47 KB

patch

obsolete

>From f4b73f5be6f89fc139f19c89024aedc68e34ecfb Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Fri, 28 Oct 2011 13:28:37 -0400
>Subject: [PATCH 1/2] drm/radeon/kms: properly set panel mode for eDP
>
>This should make eDP more reliable.
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/radeon/atombios_dp.c |   11 +++++++++++
> include/drm/drm_dp_helper.h          |    3 +++
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
>index 16de05f..ff47186 100644
>--- a/drivers/gpu/drm/radeon/atombios_dp.c
>+++ b/drivers/gpu/drm/radeon/atombios_dp.c
>@@ -554,6 +554,7 @@ static void radeon_dp_set_panel_mode(struct drm_encoder *encoder,
> {
> 	struct drm_device *dev = encoder->dev;
> 	struct radeon_device *rdev = dev->dev_private;
>+	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
> 	int panel_mode = DP_PANEL_MODE_EXTERNAL_DP_MODE;
> 
> 	if (!ASIC_IS_DCE4(rdev))
>@@ -562,10 +563,20 @@ static void radeon_dp_set_panel_mode(struct drm_encoder *encoder,
> 	if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
> 	    ENCODER_OBJECT_ID_NONE)
> 		panel_mode = DP_PANEL_MODE_INTERNAL_DP1_MODE;
>+	else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
>+		u8 tmp = radeon_read_dpcd_reg(radeon_connector, DP_EDP_CONFIGURATION_CAP);
>+		if (tmp & 1)
>+			panel_mode = DP_PANEL_MODE_INTERNAL_DP2_MODE;
>+	}
> 
> 	atombios_dig_encoder_setup(encoder,
> 				   ATOM_ENCODER_CMD_SETUP_PANEL_MODE,
> 				   panel_mode);
>+
>+	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) &&
>+	    (panel_mode == DP_PANEL_MODE_INTERNAL_DP2_MODE)) {
>+		radeon_write_dpcd_reg(radeon_connector, DP_EDP_CONFIGURATION_SET, 1);
>+	}
> }
> 
> void radeon_dp_set_link_config(struct drm_connector *connector,
>diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>index 0d2f727..93df2d7 100644
>--- a/include/drm/drm_dp_helper.h
>+++ b/include/drm/drm_dp_helper.h
>@@ -72,6 +72,7 @@
> 
> #define DP_MAIN_LINK_CHANNEL_CODING         0x006
> 
>+#define DP_EDP_CONFIGURATION_CAP            0x00d
> #define DP_TRAINING_AUX_RD_INTERVAL         0x00e
> 
> #define DP_PSR_SUPPORT                      0x070
>@@ -159,6 +160,8 @@
> # define DP_CP_IRQ			    (1 << 2)
> # define DP_SINK_SPECIFIC_IRQ		    (1 << 6)
> 
>+#define DP_EDP_CONFIGURATION_SET            0x10a
>+
> #define DP_LANE0_1_STATUS		    0x202
> #define DP_LANE2_3_STATUS		    0x203
> # define DP_LANE_CR_DONE		    (1 << 0)
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 41569: 52095 | 52096 | 52097 | 52865 | 52866 | 55400 | 55401 | 55530 | 55531 | 56457

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.