Attachment 78646 Details for Bug 64083 – tests: avoid an out-of-range int literal

[patch] tests: avoid an out-of-range int literal

0001-tests-avoid-an-out-of-range-int-literal.patch (text/plain), 1.06 KB, created by Simon McVittie on 2013-04-30 11:52:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-04-30 11:52:15 UTC

Size: 1.06 KB

patch

obsolete

>From 616acbfe435b6905a020b26bff582c189e0e2c96 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 30 Apr 2013 12:49:23 +0100
>Subject: [PATCH] tests: avoid an out-of-range int literal
>
>In this particular test case, the expected result according to the flags
>is "it fails", so the second column (expected converted value) is not
>relevant.
>
>This apparently causes build warnings (fatal by default) on ILP32
>platforms, because 2147483648 is out-of-range for a signed int or
>signed long on such platforms. It's certainly also out-of-range for
>the struct member it's initializing, which is a gint32.
>---
> tests/keyfile.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/keyfile.c b/tests/keyfile.c
>index df891ce..93188ee 100644
>--- a/tests/keyfile.c
>+++ b/tests/keyfile.c
>@@ -102,7 +102,7 @@ struct {
>     { "001", 1, NOT_NORMALIZED },
>     { "042", 42, NOT_NORMALIZED },
>     { "2147483647", 2147483647, 0 },
>-    { "2147483648", 2147483648, FAILS },
>+    { "2147483648", 0, FAILS },
>     { NULL, 0, 0 }
> };
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 64083: 78646

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.